Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>,
	Clement LE GOFFIC <clement.legoffic@foss.st.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 7/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp25
Date: Wed, 26 Feb 2025 22:27:26 +0100	[thread overview]
Message-ID: <1de58672-5355-4b75-99f4-c48687017d2f@kernel.org> (raw)
In-Reply-To: <248f63ff-b6ec-4f58-8a96-7aee2fcd6038@foss.st.com>

On 26/02/2025 17:54, Alexandre TORGUE wrote:
>>>> But, if it's not clean to do it in this way, lets define SoC compatible
>>>> for any new driver.
>>>
>>> Compatibles are for hardware.
>>>
>>>> For the HDP case it is: "st,stm32mp157" and used for STM32MP13,
>>>> STM32MP15 end STM32MP25 SoC families (if driver is the same for all
>>>> those SoCs).
>>>
>>> No, it's three compatibles, because you have three SoCs. BTW, writing
>>> bindings (and online resources and previous reviews and my talks) are
>>> saying that, so we do not ask for anything new here, anything different.
>>> At least not new when looking at last 5 years, because 10 years ago many
>>> rules were relaxed...
>>
>> So adding 3 times the same IP in 3 different SoCs implies to have 3 
>> different compatibles. So each time we use this same IP in a new SoC, we 
>> have to add a new compatible. My (wrong) understanding was: as we have 
>> the same IP (same hardware) in each SoC we have the same compatible (and 
>> IP integration differences (clocks, interrupts) are handled by DT 
>> properties.
> 
> Just to complete, reading the Linux kernel doc, as device are same we 
> will use fallbacks like this:
> 
> MP15: compatible = "st,stm32mp151-hdp";
> MP13: compatible = "st,stm32mp131-hdp", "st,stm32mp151-hdp";
> MP25: compatible = "st,stm32mp251-hdp", "st,stm32mp151-hdp";

Yes, this looks correct.

Best regards,
Krzysztof

  reply	other threads:[~2025-02-26 21:27 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25  8:47 [PATCH 0/9] Introduce HDP support for STM32MP platforms Clément Le Goffic
2025-02-25  8:48 ` [PATCH 1/9] dt-bindings: pinctrl: stm32: Add HDP includes for stm32mp platforms Clément Le Goffic
2025-02-25 13:01   ` Krzysztof Kozlowski
2025-02-25 15:46     ` Clement LE GOFFIC
2025-02-26  7:19       ` Krzysztof Kozlowski
2025-02-25  8:48 ` [PATCH 2/9] dt-bindings: pinctrl: stm32: Introduce HDP Clément Le Goffic
2025-02-25 13:04   ` Krzysztof Kozlowski
2025-02-25 15:51     ` Clement LE GOFFIC
2025-02-26  7:21       ` Krzysztof Kozlowski
2025-02-26 10:52         ` Clement LE GOFFIC
2025-02-26 15:05           ` Krzysztof Kozlowski
2025-02-27 11:05             ` Clement LE GOFFIC
2025-02-25  8:48 ` [PATCH 3/9] pinctrl: stm32: Introduce HDP driver Clément Le Goffic
2025-02-25 12:59   ` Krzysztof Kozlowski
2025-02-25 16:05     ` Clement LE GOFFIC
2025-02-25  8:48 ` [PATCH 4/9] MAINTAINERS: Add Clément Le Goffic as STM32 HDP maintainer Clément Le Goffic
2025-02-25  8:48 ` [PATCH 5/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp13 Clément Le Goffic
2025-02-25  8:48 ` [PATCH 6/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp15 Clément Le Goffic
2025-02-25  8:48 ` [PATCH 7/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp25 Clément Le Goffic
2025-02-25 13:05   ` Krzysztof Kozlowski
2025-02-25 16:09     ` Clement LE GOFFIC
2025-02-26  7:23       ` Krzysztof Kozlowski
2025-02-26  9:33         ` Alexandre TORGUE
2025-02-26 15:08           ` Krzysztof Kozlowski
2025-02-26 15:30             ` Alexandre TORGUE
2025-02-26 16:54               ` Alexandre TORGUE
2025-02-26 21:27                 ` Krzysztof Kozlowski [this message]
2025-02-26 21:26               ` Krzysztof Kozlowski
2025-02-26 21:31                 ` Krzysztof Kozlowski
2025-02-27 12:16                   ` Alexandre TORGUE
2025-02-25  8:48 ` [PATCH 8/9] ARM: dts: stm32: add alternate pinmux for HDP pin and add HDP pinctrl node Clément Le Goffic
2025-02-25  8:48 ` [PATCH 9/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp157c-dk2 board Clément Le Goffic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1de58672-5355-4b75-99f4-c48687017d2f@kernel.org \
    --to=krzk@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=brgl@bgdev.pl \
    --cc=clement.legoffic@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox