Re: [PATCH 1/9] dt-bindings: pinctrl: stm32: Add HDP includes for stm32mp platforms

[Krzysztof Kozlowski <krzk@kernel.org>]

On 25/02/2025 09:48, Clément Le Goffic wrote:
> Each file introduces helpers to choose the signal to monitor through the
> HDP pin.
> Signals are different for each platforms: stm32mp13, stm32mp15, stm32mp25.

Headers are part of bindings commit, assuming this stays...


> 
> Signed-off-by: Clément Le Goffic <clement.legoffic@foss.st.com>
> ---
>  include/dt-bindings/pinctrl/stm32mp13-hdp.h | 130 +++++++++++++++++++++++++
>  include/dt-bindings/pinctrl/stm32mp15-hdp.h | 116 ++++++++++++++++++++++
>  include/dt-bindings/pinctrl/stm32mp25-hdp.h | 144 ++++++++++++++++++++++++++++
>  3 files changed, 390 insertions(+)
> 
> diff --git a/include/dt-bindings/pinctrl/stm32mp13-hdp.h b/include/dt-bindings/pinctrl/stm32mp13-hdp.h
> new file mode 100644
> index 000000000000..a3487e700143
> --- /dev/null
> +++ b/include/dt-bindings/pinctrl/stm32mp13-hdp.h
> @@ -0,0 +1,130 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
> +/*
> + * Copyright (C) STMicroelectronics 2025 - All Rights Reserved
> + * Author: Clément Le Goffic <clement.legoffic@foss.st.com> for STMicroelectronics.
> + */
> +
> +#ifndef _DT_BINDINGS_STM32MP13_HDP_H
> +#define _DT_BINDINGS_STM32MP13_HDP_H
> +
> +/* define a macro for each function a HDP pin can transmit */
> +#define HDP0_PWR_PWRWAKE_SYS			 "0"


Why this is a string not a number?

Where is it used? I don't see usage in the driver, so this does not look
like binding (and DTS is not a driver).

Best regards,
Krzysztof