From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Clément Le Goffic" <clement.legoffic@foss.st.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Bartosz Golaszewski" <brgl@bgdev.pl>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 7/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp25
Date: Tue, 25 Feb 2025 14:05:37 +0100 [thread overview]
Message-ID: <418a80a9-8c08-4dd1-bf49-1bd7378321aa@kernel.org> (raw)
In-Reply-To: <20250225-hdp-upstream-v1-7-9d049c65330a@foss.st.com>
On 25/02/2025 09:48, Clément Le Goffic wrote:
> Add the hdp devicetree node for stm32mp25 SoC family
>
> Signed-off-by: Clément Le Goffic <clement.legoffic@foss.st.com>
> ---
> arch/arm64/boot/dts/st/stm32mp251.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> index f3c6cdfd7008..43aaed4fcf10 100644
> --- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> @@ -918,6 +918,13 @@ package_otp@1e8 {
> };
> };
>
> + hdp: pinctrl@44090000 {
> + compatible = "st,stm32mp-hdp";
So here again - you have stm32mp251 SoC, but use entirely different
compatible.
Same feedback as with previous patchsets from ST. Please take it inside,
digest internally and do not repeat same issues.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-25 13:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 8:47 [PATCH 0/9] Introduce HDP support for STM32MP platforms Clément Le Goffic
2025-02-25 8:48 ` [PATCH 1/9] dt-bindings: pinctrl: stm32: Add HDP includes for stm32mp platforms Clément Le Goffic
2025-02-25 13:01 ` Krzysztof Kozlowski
2025-02-25 15:46 ` Clement LE GOFFIC
2025-02-26 7:19 ` Krzysztof Kozlowski
2025-02-25 8:48 ` [PATCH 2/9] dt-bindings: pinctrl: stm32: Introduce HDP Clément Le Goffic
2025-02-25 13:04 ` Krzysztof Kozlowski
2025-02-25 15:51 ` Clement LE GOFFIC
2025-02-26 7:21 ` Krzysztof Kozlowski
2025-02-26 10:52 ` Clement LE GOFFIC
2025-02-26 15:05 ` Krzysztof Kozlowski
2025-02-27 11:05 ` Clement LE GOFFIC
2025-02-25 8:48 ` [PATCH 3/9] pinctrl: stm32: Introduce HDP driver Clément Le Goffic
2025-02-25 12:59 ` Krzysztof Kozlowski
2025-02-25 16:05 ` Clement LE GOFFIC
2025-02-25 8:48 ` [PATCH 4/9] MAINTAINERS: Add Clément Le Goffic as STM32 HDP maintainer Clément Le Goffic
2025-02-25 8:48 ` [PATCH 5/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp13 Clément Le Goffic
2025-02-25 8:48 ` [PATCH 6/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp15 Clément Le Goffic
2025-02-25 8:48 ` [PATCH 7/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp25 Clément Le Goffic
2025-02-25 13:05 ` Krzysztof Kozlowski [this message]
2025-02-25 16:09 ` Clement LE GOFFIC
2025-02-26 7:23 ` Krzysztof Kozlowski
2025-02-26 9:33 ` Alexandre TORGUE
2025-02-26 15:08 ` Krzysztof Kozlowski
2025-02-26 15:30 ` Alexandre TORGUE
2025-02-26 16:54 ` Alexandre TORGUE
2025-02-26 21:27 ` Krzysztof Kozlowski
2025-02-26 21:26 ` Krzysztof Kozlowski
2025-02-26 21:31 ` Krzysztof Kozlowski
2025-02-27 12:16 ` Alexandre TORGUE
2025-02-25 8:48 ` [PATCH 8/9] ARM: dts: stm32: add alternate pinmux for HDP pin and add HDP pinctrl node Clément Le Goffic
2025-02-25 8:48 ` [PATCH 9/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp157c-dk2 board Clément Le Goffic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418a80a9-8c08-4dd1-bf49-1bd7378321aa@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=brgl@bgdev.pl \
--cc=clement.legoffic@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox