From: Guenter Roeck <linux@roeck-us.net>
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 3/5] hwmon/w83781d: Drop REALLY_SLOW_IO setting
Date: Wed, 26 Nov 2025 09:05:00 -0800 [thread overview]
Message-ID: <1b94c998-2a51-4e27-80a7-7a1906b648cb@roeck-us.net> (raw)
In-Reply-To: <20251126162018.5676-4-jgross@suse.com>
On Wed, Nov 26, 2025 at 05:20:16PM +0100, Juergen Gross wrote:
> In w83781d_isa_found() there is REALLY_SLOW_IO defined around some port
> accesses, probably in order to wait between multiple accesses.
>
> Unfortunately this isn't making any difference compared to not having
> this define since more than a decade, as REALLY_SLOW_IO needs to be
> defined while "#include <asm/io.h>" is called to have an effect.
>
> As there seem not to be any outstanding issues in spite of this having
> no effect, just drop the "#define" and add a remark to the related
> comment.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Applied.
Thanks,
Guenter
next prev parent reply other threads:[~2025-11-26 17:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 16:20 [PATCH 0/5] x86: Cleanups around slow_down_io() Juergen Gross
2025-11-26 16:20 ` [PATCH 2/5] hwmon/lm78: Drop REALLY_SLOW_IO setting Juergen Gross
2025-11-26 17:04 ` Guenter Roeck
2025-11-26 16:20 ` [PATCH 3/5] hwmon/w83781d: " Juergen Gross
2025-11-26 17:05 ` Guenter Roeck [this message]
2025-11-26 17:08 ` [PATCH 0/5] x86: Cleanups around slow_down_io() Guenter Roeck
2025-12-14 8:05 ` Ingo Molnar
2025-12-15 6:36 ` Jürgen Groß
2025-12-16 13:48 ` Ingo Molnar
2025-12-16 13:55 ` Jürgen Groß
2025-12-16 15:32 ` H. Peter Anvin
2025-12-16 19:59 ` David Laight
2025-12-16 21:50 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b94c998-2a51-4e27-80a7-7a1906b648cb@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jgross@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox