From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>, Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH 2/5] hwmon/lm78: Drop REALLY_SLOW_IO setting
Date: Wed, 26 Nov 2025 17:20:15 +0100 [thread overview]
Message-ID: <20251126162018.5676-3-jgross@suse.com> (raw)
In-Reply-To: <20251126162018.5676-1-jgross@suse.com>
In lm78_isa_found() there is REALLY_SLOW_IO defined around some port
accesses, probably in order to wait between multiple accesses.
Unfortunately this isn't making any difference compared to not having
this define since more than a decade, as REALLY_SLOW_IO needs to be
defined while "#include <asm/io.h>" is called to have an effect.
As there seem not to be any outstanding issues in spite of this having
no effect, just drop the "#define" and add a remark to the related
comment.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
drivers/hwmon/lm78.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/lm78.c b/drivers/hwmon/lm78.c
index 8b53bb312069..9378a47bf5af 100644
--- a/drivers/hwmon/lm78.c
+++ b/drivers/hwmon/lm78.c
@@ -843,17 +843,18 @@ static int __init lm78_isa_found(unsigned short address)
}
}
-#define REALLY_SLOW_IO
/*
* We need the timeouts for at least some LM78-like
* chips. But only if we read 'undefined' registers.
+ * There used to be a "#define REALLY_SLOW_IO" to enforce that, but
+ * this has been without any effect since more than a decade, so it
+ * has been dropped.
*/
val = inb_p(address + 1);
if (inb_p(address + 2) != val
|| inb_p(address + 3) != val
|| inb_p(address + 7) != val)
goto release;
-#undef REALLY_SLOW_IO
/*
* We should be able to change the 7 LSB of the address port. The
--
2.51.0
next prev parent reply other threads:[~2025-11-26 16:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 16:20 [PATCH 0/5] x86: Cleanups around slow_down_io() Juergen Gross
2025-11-26 16:20 ` Juergen Gross [this message]
2025-11-26 17:04 ` [PATCH 2/5] hwmon/lm78: Drop REALLY_SLOW_IO setting Guenter Roeck
2025-11-26 16:20 ` [PATCH 3/5] hwmon/w83781d: " Juergen Gross
2025-11-26 17:05 ` Guenter Roeck
2025-11-26 17:08 ` [PATCH 0/5] x86: Cleanups around slow_down_io() Guenter Roeck
2025-12-14 8:05 ` Ingo Molnar
2025-12-15 6:36 ` Jürgen Groß
2025-12-16 13:48 ` Ingo Molnar
2025-12-16 13:55 ` Jürgen Groß
2025-12-16 15:32 ` H. Peter Anvin
2025-12-16 19:59 ` David Laight
2025-12-16 21:50 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251126162018.5676-3-jgross@suse.com \
--to=jgross@suse.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox