Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Akshay Gupta <Akshay.Gupta@amd.com>
To: <linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>
Cc: <linux@roeck-us.net>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <corbet@lwn.net>,
	<skhan@linuxfoundation.org>, <rdunlap@infradead.org>,
	<arnd@arndb.de>, <gregkh@linuxfoundation.org>,
	<naveenkrishna.chatradhi@amd.com>, <Anand.Umarji@amd.com>,
	Prathima Lk <Prathima.Lk@amd.com>,
	Akshay Gupta <Akshay.Gupta@amd.com>
Subject: [PATCH v1 4/4] Documentation: hwmon: document DIMM thermal sensor channels
Date: Mon, 16 Nov 2026 17:32:28 +0530	[thread overview]
Message-ID: <20261116120228.865196-5-Akshay.Gupta@amd.com> (raw)
In-Reply-To: <20261116120228.865196-1-Akshay.Gupta@amd.com>

From: Prathima Lk <Prathima.Lk@amd.com>

sbrmi.rst described only the power1_* attributes. Document the
tempX_input and tempX_label attributes for the DIMM thermal sensors,
the DIMM to temp index mapping for one and two DIMMs per channel, the
DIMM_TS<t>_UMC<n> labels and the effect of amd,dimm-ids, and add a
sysfs read example.

Also point to it from the SB-RMI section of
Documentation/misc-devices/amd-sbi.rst, which listed only the power
attributes.

Signed-off-by: Prathima Lk <Prathima.Lk@amd.com>
Signed-off-by: Akshay Gupta <Akshay.Gupta@amd.com>
---
 Documentation/hwmon/sbrmi.rst          | 37 ++++++++++++++++++++++++++
 Documentation/misc-devices/amd-sbi.rst |  4 ++-
 2 files changed, 40 insertions(+), 1 deletion(-)

diff --git a/Documentation/hwmon/sbrmi.rst b/Documentation/hwmon/sbrmi.rst
index 296049e13ac9..08859763658b 100644
--- a/Documentation/hwmon/sbrmi.rst
+++ b/Documentation/hwmon/sbrmi.rst
@@ -41,6 +41,8 @@ power on AMD platforms using mailbox command and resembles a typical 8-pin remot
 power sensor's I2C interface to BMC.
 
 This driver implements current power with power cap and power cap max.
+It also reports DIMM thermal sensor (TS0 and TS1) temperatures read with
+the SB-RMI DIMM thermal mailbox command.
 
 sysfs-Interface
 ---------------
@@ -57,6 +59,28 @@ power1_cap       RW    Power limit can be set between 0 and power1_cap_max
 power1_cap_max   RO    Maximum powerlimit calculated and reported by the SMU FW
 ================ ===== ========================================================
 
+DIMM thermal sensors are reported as temperature channels:
+
+================ ===== ========================================================
+Name             Perm   Description
+================ ===== ========================================================
+tempX_input      RO    DIMM thermal sensor temperature in milli-degrees Celsius
+tempX_label      RO    Channel label, ``DIMM_TS0_UMCn`` or ``DIMM_TS1_UMCn``
+                       (n = 0..15)
+================ ===== ========================================================
+
+Each DIMM has two sensors, TS0 and TS1. DIMM ``n`` (0-15) is reported on
+``temp(n+1)_*`` (TS0) and ``temp(n+17)_*`` (TS1). With one DIMM per memory
+channel (the default), ``n`` is the memory channel and the labels are
+``DIMM_TS0_UMCn`` and ``DIMM_TS1_UMCn``. With two
+(``amd,dpc = /bits/ 8 <2>``), ``n`` is memory channel * 2 + slot,
+the DIMM number on the board, with the same labels.
+
+The optional ``amd,dimm-ids`` firmware property lists the DIMM_ADDRESS of
+each sensor (TS0 or TS1) and only those sensors are reported; without it,
+all 16 DIMMs are reported. A read fails with an error if the DIMM or sensor
+is not present or the firmware rejects the command.
+
 The following example show how the 'Power' attribute from the i2c-addresses
 can be monitored using the userspace utilities like ``sensors`` binary::
 
@@ -77,3 +101,16 @@ Also, Below shows how get and set the values from sysfs entries individually::
   # echo 180000000 > /sys/class/hwmon/hwmon1/power1_cap
   # cat /sys/class/hwmon/hwmon1/power1_cap
   180000000
+
+Reading the TS0 and TS1 sensors of the first DIMM without ``amd,dimm-ids``
+(temperatures are in milli-degrees Celsius)::
+
+  # cat /sys/class/hwmon/hwmonN/temp1_label
+  DIMM_TS0_UMC0
+  # cat /sys/class/hwmon/hwmonN/temp1_input
+  42000
+
+  # cat /sys/class/hwmon/hwmonN/temp17_label
+  DIMM_TS1_UMC0
+  # cat /sys/class/hwmon/hwmonN/temp17_input
+  41750
diff --git a/Documentation/misc-devices/amd-sbi.rst b/Documentation/misc-devices/amd-sbi.rst
index 648d743903b7..a1ef4872c90f 100644
--- a/Documentation/misc-devices/amd-sbi.rst
+++ b/Documentation/misc-devices/amd-sbi.rst
@@ -34,7 +34,9 @@ among protocols as transactions may create race condition.
    crw-------    1 root     root       10,  53 Jul 10 11:13 /dev/sbrmi-3c
 
 apml_sbrmi driver registers hwmon sensors for monitoring power_cap_max,
-current power consumption and managing power_cap.
+current power consumption and managing power_cap. It also reports the
+TS0/TS1 DIMM thermal sensors as temperature channels; see
+Documentation/hwmon/sbrmi.rst.
 
 Characteristics of the dev node:
  * Differnet xfer protocols are defined:
-- 
2.34.1


  parent reply	other threads:[~2026-11-16 12:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 12:02 [PATCH v1 0/4] misc: amd-sbi: add DIMM thermal sensors to sbrmi Akshay Gupta
2026-11-16 12:02 ` [PATCH v1 1/4] misc: amd-sbi: use guard() for data->lock mutex Akshay Gupta
2026-11-16 12:15   ` sashiko-bot
2026-11-16 12:02 ` [PATCH v1 2/4] dt-bindings: hwmon: add DIMM thermal sensor properties Akshay Gupta
2026-11-16 12:11   ` sashiko-bot
2026-11-16 12:02 ` [PATCH v1 3/4] misc: amd-sbi: add DIMM thermal sensor support Akshay Gupta
2026-11-16 12:13   ` sashiko-bot
2026-11-16 12:02 ` Akshay Gupta [this message]
2026-11-16 12:08   ` [PATCH v1 4/4] Documentation: hwmon: document DIMM thermal sensor channels sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116120228.865196-5-Akshay.Gupta@amd.com \
    --to=akshay.gupta@amd.com \
    --cc=Anand.Umarji@amd.com \
    --cc=Prathima.Lk@amd.com \
    --cc=arnd@arndb.de \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=naveenkrishna.chatradhi@amd.com \
    --cc=rdunlap@infradead.org \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox