From: sashiko-bot@kernel.org
To: "Akshay Gupta" <Akshay.Gupta@amd.com>, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v1 2/4] dt-bindings: hwmon: add DIMM thermal sensor properties
Date: Mon, 16 Nov 2026 12:11:52 +0000 [thread overview]
Message-ID: <sashiko-outbox-216990@kernel.org> (raw)
In-Reply-To: <20261116120228.865196-3-Akshay.Gupta@amd.com>
> From: Prathima Lk <Prathima.Lk@amd.com>
>
> The SB-RMI mailbox also reports the temperature of the TS0/TS1 thermal
> sensors on each DIMM (command 0x48, Mode 1 DIMM_ADDRESS). Boards differ
> in how many DIMMs are fitted per memory channel and which sensors are
> populated, so describe both in the binding.
>
> Add two optional properties:
>
> - amd,dpc: uint8, DIMMs per channel, 1 or 2 (default 1).
>
> - amd,dimm-ids: uint8 array of 1 to 32 unique Mode 1 DIMM_ADDRESS
> values, one per sensor to report. Encoding: bit[7]=1 (Mode 1),
> bit[6] sensor (0=TS0, 1=TS1), bit[5] reserved, bit[4] DIMM slot,
> bit[3:0] memory channel. When absent, the TS0 and TS1 sensors of
> all 16 DIMMs are reported.
>
> The allowed amd,dimm-ids values depend on amd,dpc: with one DIMM per
> channel 0x80-0x8f and 0xc0-0xcf; with two, 0x80-0x87, 0x90-0x97,
> 0xc0-0xc7 and 0xd0-0xd7. This rejects the reserved bit, a slot bit
> without a second DIMM, and channels above 7 with two DIMMs per channel.
>
> Also mention the DIMM sensors in the title and description and extend
> the example.
>
> Signed-off-by: Prathima Lk <Prathima.Lk@amd.com>
> Signed-off-by: Akshay Gupta <Akshay.Gupta@amd.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116120228.865196-1-Akshay.Gupta@amd.com?part=2
next prev parent reply other threads:[~2026-11-16 12:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 12:02 [PATCH v1 0/4] misc: amd-sbi: add DIMM thermal sensors to sbrmi Akshay Gupta
2026-11-16 12:02 ` [PATCH v1 1/4] misc: amd-sbi: use guard() for data->lock mutex Akshay Gupta
2026-11-16 12:15 ` sashiko-bot
2026-11-16 12:02 ` [PATCH v1 2/4] dt-bindings: hwmon: add DIMM thermal sensor properties Akshay Gupta
2026-11-16 12:11 ` sashiko-bot [this message]
2026-11-16 12:02 ` [PATCH v1 3/4] misc: amd-sbi: add DIMM thermal sensor support Akshay Gupta
2026-11-16 12:13 ` sashiko-bot
2026-11-16 12:02 ` [PATCH v1 4/4] Documentation: hwmon: document DIMM thermal sensor channels Akshay Gupta
2026-11-16 12:08 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216990@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Akshay.Gupta@amd.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox