Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Akshay Gupta" <Akshay.Gupta@amd.com>, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v1 3/4] misc: amd-sbi: add DIMM thermal sensor support
Date: Mon, 16 Nov 2026 12:13:29 +0000	[thread overview]
Message-ID: <sashiko-outbox-216996@kernel.org> (raw)
In-Reply-To: <20261116120228.865196-4-Akshay.Gupta@amd.com>

> From: Prathima Lk <Prathima.Lk@amd.com>
> 
> Report the TS0 and TS1 thermal sensors of up to 16 DIMMs as 32 hwmon
> temperature channels using SB-RMI mailbox command 0x48 with the Mode 1
> DIMM_ADDRESS encoding:
> 
>   bit[7]   1 (Mode 1)
>   bit[6]   sensor select (0 = TS0, 1 = TS1)
>   bit[5]   reserved
>   bit[4]   DIMM slot
>   bit[3:0] memory channel
> 
> Board DIMM n is reported on temp(n+1) (TS0) and temp(n+17) (TS1), where
> n = memory channel * DIMMs-per-channel + slot. With one DIMM per channel
> n is the memory channel; with two, the slots interleave (0x80, 0x90,
> [ ... ]
> complement value in 0.25 degC steps and is reported in millidegrees
> Celsius.
> 
> Signed-off-by: Prathima Lk <Prathima.Lk@amd.com>
> Signed-off-by: Akshay Gupta <Akshay.Gupta@amd.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116120228.865196-1-Akshay.Gupta@amd.com?part=3


  reply	other threads:[~2026-11-16 12:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 12:02 [PATCH v1 0/4] misc: amd-sbi: add DIMM thermal sensors to sbrmi Akshay Gupta
2026-11-16 12:02 ` [PATCH v1 1/4] misc: amd-sbi: use guard() for data->lock mutex Akshay Gupta
2026-11-16 12:15   ` sashiko-bot
2026-11-16 12:02 ` [PATCH v1 2/4] dt-bindings: hwmon: add DIMM thermal sensor properties Akshay Gupta
2026-11-16 12:11   ` sashiko-bot
2026-11-16 12:02 ` [PATCH v1 3/4] misc: amd-sbi: add DIMM thermal sensor support Akshay Gupta
2026-11-16 12:13   ` sashiko-bot [this message]
2026-11-16 12:02 ` [PATCH v1 4/4] Documentation: hwmon: document DIMM thermal sensor channels Akshay Gupta
2026-11-16 12:08   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216996@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Akshay.Gupta@amd.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox