[PATCH v1] drivers/i2c/muxes:Fix resource leaks in device_for_each_child_node() loops

[PATCH v1] drivers/i2c/muxes:Fix resource leaks in device_for_each_child_node() loops

[Wang Ming]

The device_for_each_child_node loop in i2c-mux-gpio should
have fwnode_handle_put() before return which could avoid
resource leaks.This patch could fix this bug.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/i2c/muxes/i2c-mux-gpio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
index 5d5cbe013..90966de7a 100644
--- a/drivers/i2c/muxes/i2c-mux-gpio.c
+++ b/drivers/i2c/muxes/i2c-mux-gpio.c
@@ -106,6 +106,7 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
                } else if (is_acpi_node(child)) {
                        rc = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), values + i);
                        if (rc)
+                               fwnode_handle_put(child);
                                return dev_err_probe(dev, rc, "Cannot get address\n");
                }

--
2.25.1


________________________________
本邮件及其附件内容可能含有机密和/或隐私信息，仅供指定个人或机构使用。若您非发件人指定收件人或其代理人，请勿使用、传播、复制或存储此邮件之任何内容或其附件。如您误收本邮件，请即以回复或电话方式通知发件人，并将原始邮件、附件及其所有复本删除。谢谢。
The contents of this message and any attachments may contain confidential and/or privileged information and are intended exclusively for the addressee(s). If you are not the intended recipient of this message or their agent, please note that any use, dissemination, copying, or storage of this message or its attachments is not allowed. If you receive this message in error, please notify the sender by reply the message or phone and delete this message, any attachments and any copies immediately.
Thank you

Re: [PATCH v1] drivers/i2c/muxes:Fix resource leaks in device_for_each_child_node() loops

[Andi Shyti]

Hi Wang,

> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index 5d5cbe013..90966de7a 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -106,6 +106,7 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
>                 } else if (is_acpi_node(child)) {
>                         rc = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), values + i);
>                         if (rc)
> +                               fwnode_handle_put(child);
>                                 return dev_err_probe(dev, rc, "Cannot get address\n");
>                 }

please, read it again and tell me what's wrong :)

Andi

Re: [PATCH v1] drivers/i2c/muxes:Fix resource leaks in device_for_each_child_node() loops

[Krzysztof Kozlowski]

On 14/06/2023 13:43, Andi Shyti wrote:
> Hi Wang,
> 
>> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
>> index 5d5cbe013..90966de7a 100644
>> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
>> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
>> @@ -106,6 +106,7 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
>>                 } else if (is_acpi_node(child)) {
>>                         rc = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), values + i);
>>                         if (rc)
>> +                               fwnode_handle_put(child);
>>                                 return dev_err_probe(dev, rc, "Cannot get address\n");
>>                 }
> 
> please, read it again and tell me what's wrong :)


No, we can't tell what's wrong because:

> The contents of this message and any attachments may contain
> confidential and/or privileged information

:)

Wang,
Just run the sparse and smatch before posting patches.

Best regards,
Krzysztof