Re: [PATCH 3/3] arm64: dts: qcom: talos-evk-camera: Add DT overlay

[Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>]

On 12/24/2025 12:36 AM, Vladimir Zapolskiy wrote:
> On 12/23/25 04:16, Wenmeng Liu wrote:
>>
>>
>> On 12/22/2025 11:45 PM, Vladimir Zapolskiy wrote:
>>> On 12/22/25 13:41, Wenmeng Liu wrote:
>>>>
>>>>
>>>> On 12/22/2025 7:19 PM, Vladimir Zapolskiy wrote:
>>>>> On 12/22/25 10:44, Wenmeng Liu wrote:
>>>>>> Enable IMX577 via CCI on Taloss EVK Core Kit.
>>>>>>
>>>>>> The Talos EVK board does not include a camera sensor
>>>>>> by default, this overlay reflects the possibility of
>>>>>> attaching an optional camera sensor.
>>>>>> For this reason, the camera sensor configuration is
>>>>>> placed in talos-evk-camera.dtso, rather than
>>>>>> modifying the base talos-evk.dts.
>>>>>>
>>>>>> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
>>>>>> ---
>>>>>>     arch/arm64/boot/dts/qcom/Makefile              |  2 +
>>>>>>     arch/arm64/boot/dts/qcom/talos-evk-camera.dtso | 64 ++++++++++ 
>>>>>> ++++++
>>>>>> ++++++++++
>>>>>>     arch/arm64/boot/dts/qcom/talos.dtsi            | 21 +++++++++
>>>>>
>>>>> Please split QCS615 MCLK definitions change into a separate commit.
>>>> ACK.>
>>>>>>     3 files changed, 87 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/
>>>>>> qcom/Makefile
>>>>>> index
>>>>>> 60121f133078b2754f98e6f45a3db4031b478cc8..b1d85b1f4a94714f2a5c976d162482d70ae920f2 100644
>>>>>> --- a/arch/arm64/boot/dts/qcom/Makefile
>>>>>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>>>>>> @@ -325,7 +325,9 @@ dtb-$(CONFIG_ARCH_QCOM)    += sm8650-qrd.dtb
>>>>>>     dtb-$(CONFIG_ARCH_QCOM)    += sm8750-mtp.dtb
>>>>>>     dtb-$(CONFIG_ARCH_QCOM)    += sm8750-qrd.dtb
>>>>>>     dtb-$(CONFIG_ARCH_QCOM)    += talos-evk.dtb
>>>>>> +talos-evk-camera-dtbs        := talos-evk.dtb talos-evk-camera.dtbo
>>>>>>     talos-evk-lvds-auo,g133han01-dtbs    := talos-evk.dtb talos-evk-
>>>>>> lvds-auo,g133han01.dtbo
>>>>>> +dtb-$(CONFIG_ARCH_QCOM)    += talos-evk-camera.dtb
>>>>>>     dtb-$(CONFIG_ARCH_QCOM)    += talos-evk-lvds-auo,g133han01.dtb
>>>>>>     x1e001de-devkit-el2-dtbs    := x1e001de-devkit.dtb x1-el2.dtbo
>>>>>>     dtb-$(CONFIG_ARCH_QCOM)    += x1e001de-devkit.dtb x1e001de- 
>>>>>> devkit-
>>>>>> el2.dtb
>>>>>> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-camera.dtso b/arch/
>>>>>> arm64/boot/dts/qcom/talos-evk-camera.dtso
>>>>>> new file mode 100644
>>>>>> index
>>>>>> 0000000000000000000000000000000000000000..ae1a02295b4dc48212aad40980a329ff458fe69a
>>>>>> --- /dev/null
>>>>>> +++ b/arch/arm64/boot/dts/qcom/talos-evk-camera.dtso
>>>>>> @@ -0,0 +1,64 @@
>>>>>> +// SPDX-License-Identifier: BSD-3-Clause
>>>>>> +/*
>>>>>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its 
>>>>>> subsidiaries.
>>>>>
>>>>> Please add a missing year of the change.
>>>> Now our requirement is a yearless copyright.>
>>>
>>> Ack. It's a lawyers' domain anyway.
>>>
>>>>>> + */
>>>>>> +
>>>>>> +/dts-v1/;
>>>>>> +/plugin/;
>>>>>> +
>>>>>> +#include <dt-bindings/clock/qcom,qcs615-camcc.h>
>>>>>> +#include <dt-bindings/gpio/gpio.h>
>>>>>> +
>>>>>> +&camss {
>>>>>> +    vdd-csiphy-1p2-supply = <&vreg_l11a>;
>>>>>> +    vdd-csiphy-1p8-supply = <&vreg_l12a>;
>>>>>> +
>>>>>> +    status = "okay";
>>>>>> +
>>>>>> +    ports {
>>>>>> +        #address-cells = <1>;
>>>>>> +        #size-cells = <0>;
>>>>>> +
>>>>>> +        port@1 {
>>>>>> +            reg = <1>;
>>>>>> +
>>>>>> +            csiphy1_ep: endpoint {
>>>>>> +                clock-lanes = <7>;
>>>>>
>>>>> Please remove 'clock-lanes' property.
>>>> ACK.>
>>>>>> +                data-lanes = <0 1 2 3>;
>>>>>> +                remote-endpoint = <&imx577_ep1>;
>>>>>> +            };
>>>>>> +        };
>>>>>> +    };
>>>>>> +};
>>>>>> +
>>>>>> +&cci {
>>>>>> +    status = "okay";
>>>>>> +};
>>>>>> +
>>>>>> +&cci_i2c1 {
>>>>>> +    #address-cells = <1>;
>>>>>> +    #size-cells = <0>;
>>>>>> +
>>>>>> +    camera@1a {
>>>>>> +        compatible = "sony,imx577";
>>>>>> +        reg = <0x1a>;
>>>>>> +
>>>>>> +        reset-gpios = <&tlmm 29 GPIO_ACTIVE_LOW>;
>>>>>> +        pinctrl-0 = <&cam2_default>;
>>>>>> +        pinctrl-names = "default";
>>>>>> +
>>>>>> +        clocks = <&camcc CAM_CC_MCLK2_CLK>;
>>>>>> +        assigned-clocks = <&camcc CAM_CC_MCLK2_CLK>;
>>>>>> +        assigned-clock-rates = <24000000>;
>>>>>> +
>>>>>> +        avdd-supply = <&vreg_s4a>;
>>>>>
>>>>> Just one voltage supply?
>>>> yes, 22pin camera module only have one pin for power.>
>>>
>>> It's common that mezzanine boards are supplied with power from S4A or 
>>> VBAT,
>>> I've never seen a camera module supplied with just one voltage 
>>> regulator,
>>> that's why it attracts attention.
>>>
>>> What is a camera module here, is it on an attachable vision mezzanine 
>>> like
>>> on RBx series or a part of Talos EVK PCB like on QRD series?
>>>
>>> If it is a mezzanine, the support of mezzanine boards should be done as
>>> a DT overlay.
>>>
>>
>> It`s like RBx series, does not include a camera sensor
>> by default.
>>
> 
> Then to add the image sensor support please follow the model with DT 
> overlays,
> and it means you shall get a schematics of the mezzanine to describe the
> attachable board.
> 
> When you get the schematics, you will get a valid view on voltage 
> distribution,
> sensor supplies will be derivatives from VBAT or S4A anyway, I believe.
> 
> See sm8550-hdk-rear-camera-card.dtso or qrb5165-rb5-vision- 
> mezzanine.dtso as
> the references.
> 

yes, I think the module will distribute the supplies of S4A.

Thanks,
Wenmeng