Re: [PATCH 1/3] dt-bindings: i2c: qcom-cci: Document sm6150 compatible

[Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>]

On 12/22/2025 4:58 PM, Krzysztof Kozlowski wrote:
> On 22/12/2025 09:44, Wenmeng Liu wrote:
>> Add the sm6150 CCI device string compatible.
>>
>> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
>> ---
>>   .../devicetree/bindings/i2c/qcom,i2c-cci.yaml          | 18 ++++++++++++++++++
>>   1 file changed, 18 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>> index a3fe1eea6aece9685674feaa5ec53765c1ce23d8..cb5e6fd5b2ad1de79a9b29d54869d093c952d778 100644
>> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>> @@ -33,6 +33,7 @@ properties:
>>                 - qcom,sc8280xp-cci
>>                 - qcom,sdm670-cci
>>                 - qcom,sdm845-cci
>> +              - qcom,sm6150-cci
>>                 - qcom,sm6350-cci
>>                 - qcom,sm8250-cci
>>                 - qcom,sm8450-cci
>> @@ -263,6 +264,23 @@ allOf:
>>               - const: cpas_ahb
>>               - const: cci
>>   
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            enum:
>> +              - qcom,sm6150-cci
>> +    then:
>> +      properties:
>> +        clocks:
>> +          minItems: 3
>> +          maxItems: 3
>> +        clock-names:
>> +          items:
>> +            - const: soc_ahb
> 
> 
> Isn't this just camnoc_axi for this device (pay attention: to this device)?
> 

On this SOC, both soc_ahb and camnoc_axi exist.
Is it suggested that I use the existing ones below?
  - if:
       properties:
         compatible:
           contains:
             enum:
               - qcom,sdm670-cci
     then:
       properties:
         clocks:
           minItems: 4
           maxItems: 4
         clock-names:
           items:
             - const: camnoc_axi
             - const: soc_ahb
             - const: cpas_ahb
             - const: cci


Thanks,
Wenmeng