* [PATCH] i2c: at91: change log when dma configuration fails
@ 2016-05-13 9:22 Ludovic Desroches
2016-05-13 9:53 ` Mason
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Desroches @ 2016-05-13 9:22 UTC (permalink / raw)
To: wsa
Cc: linux-i2c, nicolas.ferre, linux-arm-kernel, linux-kernel,
Ludovic Desroches
When the DMA configuration fails, there is a log reporting that we can't
use DMA and indicating the error number. When booting the kernel, it is
annoying to see this error number. Moreover, people can think something
is going wrong. It is not the case, it means that DMA can't be used but
it doesn't prevent to use i2c.
Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
---
drivers/i2c/busses/i2c-at91.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
index 921d32b..f2a7457 100644
--- a/drivers/i2c/busses/i2c-at91.c
+++ b/drivers/i2c/busses/i2c-at91.c
@@ -1013,7 +1013,9 @@ static int at91_twi_configure_dma(struct at91_twi_dev *dev, u32 phy_addr)
error:
if (ret != -EPROBE_DEFER)
- dev_info(dev->dev, "can't use DMA, error %d\n", ret);
+ dev_info(dev->dev,
+ "can't request DMA channels, continue without DMA support\n",
+ ret);
if (dma->chan_rx)
dma_release_channel(dma->chan_rx);
if (dma->chan_tx)
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: at91: change log when dma configuration fails
2016-05-13 9:22 [PATCH] i2c: at91: change log when dma configuration fails Ludovic Desroches
@ 2016-05-13 9:53 ` Mason
2016-05-13 11:48 ` Ludovic Desroches
0 siblings, 1 reply; 3+ messages in thread
From: Mason @ 2016-05-13 9:53 UTC (permalink / raw)
To: Ludovic Desroches; +Cc: wsa, linux-i2c, nicolas.ferre
On 13/05/2016 11:22, Ludovic Desroches wrote:
> When the DMA configuration fails, there is a log reporting that we can't
> use DMA and indicating the error number. When booting the kernel, it is
> annoying to see this error number. Moreover, people can think something
> is going wrong. It is not the case, it means that DMA can't be used but
> it doesn't prevent to use i2c.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> ---
> drivers/i2c/busses/i2c-at91.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index 921d32b..f2a7457 100644
> --- a/drivers/i2c/busses/i2c-at91.c
> +++ b/drivers/i2c/busses/i2c-at91.c
> @@ -1013,7 +1013,9 @@ static int at91_twi_configure_dma(struct at91_twi_dev *dev, u32 phy_addr)
>
> error:
> if (ret != -EPROBE_DEFER)
> - dev_info(dev->dev, "can't use DMA, error %d\n", ret);
> + dev_info(dev->dev,
> + "can't request DMA channels, continue without DMA support\n",
> + ret);
Did you forget to remove 'ret' after removing the %d format spec?
Regards.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: at91: change log when dma configuration fails
2016-05-13 9:53 ` Mason
@ 2016-05-13 11:48 ` Ludovic Desroches
0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Desroches @ 2016-05-13 11:48 UTC (permalink / raw)
To: Mason; +Cc: Ludovic Desroches, wsa, linux-i2c, nicolas.ferre
On Fri, May 13, 2016 at 11:53:09AM +0200, Mason wrote:
> On 13/05/2016 11:22, Ludovic Desroches wrote:
>
> > When the DMA configuration fails, there is a log reporting that we can't
> > use DMA and indicating the error number. When booting the kernel, it is
> > annoying to see this error number. Moreover, people can think something
> > is going wrong. It is not the case, it means that DMA can't be used but
> > it doesn't prevent to use i2c.
> >
> > Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> > ---
> > drivers/i2c/busses/i2c-at91.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> > index 921d32b..f2a7457 100644
> > --- a/drivers/i2c/busses/i2c-at91.c
> > +++ b/drivers/i2c/busses/i2c-at91.c
> > @@ -1013,7 +1013,9 @@ static int at91_twi_configure_dma(struct at91_twi_dev *dev, u32 phy_addr)
> >
> > error:
> > if (ret != -EPROBE_DEFER)
> > - dev_info(dev->dev, "can't use DMA, error %d\n", ret);
> > + dev_info(dev->dev,
> > + "can't request DMA channels, continue without DMA support\n",
> > + ret);
>
> Did you forget to remove 'ret' after removing the %d format spec?
>
Oh yes, thanks. v2 is coming !
Regards
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-13 11:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-13 9:22 [PATCH] i2c: at91: change log when dma configuration fails Ludovic Desroches
2016-05-13 9:53 ` Mason
2016-05-13 11:48 ` Ludovic Desroches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox