From: Michal Simek <michal.simek@amd.com>
To: Wolfram Sang <wsa@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
<linux-i2c@vger.kernel.org>, <michal.simek@xilinx.com>,
<git-dev@amd.com>, Chirag Parekh <chiragp@xilinx.com>,
Robert Hancock <robert.hancock@calian.com>
Subject: Re: [PATCH v3] i2c: cadence: Add standard bus recovery support
Date: Thu, 29 Sep 2022 09:29:29 +0200 [thread overview]
Message-ID: <6112f323-63d2-f698-43aa-deed8aa6616c@amd.com> (raw)
In-Reply-To: <YzNei/DBUohqYlX1@shikoro>
Hi Wolfram,
On 9/27/22 22:35, Wolfram Sang wrote:
>
>> Applied to for-next, thanks!
>
> Unrelated to this patch, but cppcheck found this issue:
>
> drivers/i2c/busses/i2c-cadence.c:1038:33: warning: Condition 'actual_fscl>fscl' is always false [knownConditionTrueFalse]
> current_error = ((actual_fscl > fscl) ? (actual_fscl - fscl) :
> ^
> drivers/i2c/busses/i2c-cadence.c:1035:19: note: Assuming that condition 'actual_fscl>fscl' is not redundant
> if (actual_fscl > fscl)
> ^
> drivers/i2c/busses/i2c-cadence.c:1038:33: note: Condition 'actual_fscl>fscl' is always false
> current_error = ((actual_fscl > fscl) ? (actual_fscl - fscl) :
>
> I had a glimpse and I think the checker is correct...
Are you still using your ninja-check script?
Can you please share your latest version?
Thanks,
Michal
prev parent reply other threads:[~2022-09-29 7:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 5:51 [PATCH v3] i2c: cadence: Add standard bus recovery support Shubhrajyoti Datta
2022-07-29 10:56 ` Michal Simek
2022-07-29 11:05 ` Datta, Shubhrajyoti
2022-07-29 11:17 ` Michal Simek
2022-09-27 7:06 ` Michal Simek
2022-09-27 20:32 ` Wolfram Sang
2022-09-27 20:35 ` Wolfram Sang
2022-09-29 7:29 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6112f323-63d2-f698-43aa-deed8aa6616c@amd.com \
--to=michal.simek@amd.com \
--cc=chiragp@xilinx.com \
--cc=git-dev@amd.com \
--cc=linux-i2c@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robert.hancock@calian.com \
--cc=shubhrajyoti.datta@xilinx.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox