From: Wolfram Sang <wsa@kernel.org>
To: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
linux-i2c@vger.kernel.org, michal.simek@xilinx.com,
git-dev@amd.com, Chirag Parekh <chiragp@xilinx.com>,
Robert Hancock <robert.hancock@calian.com>
Subject: Re: [PATCH v3] i2c: cadence: Add standard bus recovery support
Date: Tue, 27 Sep 2022 22:35:23 +0200 [thread overview]
Message-ID: <YzNei/DBUohqYlX1@shikoro> (raw)
In-Reply-To: <YzNdytanT3dO1eai@shikoro>
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
> Applied to for-next, thanks!
Unrelated to this patch, but cppcheck found this issue:
drivers/i2c/busses/i2c-cadence.c:1038:33: warning: Condition 'actual_fscl>fscl' is always false [knownConditionTrueFalse]
current_error = ((actual_fscl > fscl) ? (actual_fscl - fscl) :
^
drivers/i2c/busses/i2c-cadence.c:1035:19: note: Assuming that condition 'actual_fscl>fscl' is not redundant
if (actual_fscl > fscl)
^
drivers/i2c/busses/i2c-cadence.c:1038:33: note: Condition 'actual_fscl>fscl' is always false
current_error = ((actual_fscl > fscl) ? (actual_fscl - fscl) :
I had a glimpse and I think the checker is correct...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-27 20:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 5:51 [PATCH v3] i2c: cadence: Add standard bus recovery support Shubhrajyoti Datta
2022-07-29 10:56 ` Michal Simek
2022-07-29 11:05 ` Datta, Shubhrajyoti
2022-07-29 11:17 ` Michal Simek
2022-09-27 7:06 ` Michal Simek
2022-09-27 20:32 ` Wolfram Sang
2022-09-27 20:35 ` Wolfram Sang [this message]
2022-09-29 7:29 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzNei/DBUohqYlX1@shikoro \
--to=wsa@kernel.org \
--cc=chiragp@xilinx.com \
--cc=git-dev@amd.com \
--cc=linux-i2c@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robert.hancock@calian.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox