Re: [PATCH -next] i2c: s3c2410: Remove redundant dev_err()

Re: [PATCH -next] i2c: s3c2410: Remove redundant dev_err()

[Andi Shyti]

Hi Ruan,

On Wed, Jul 26, 2023 at 05:42:26PM +0000, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as
> it is going to display an appropriate error message in case of a failure.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Correct!

Reviewed-by: Andi Shyti <andi.shyti@kernel.org> 

Andi

[PATCH -next] i2c: s3c2410: Remove redundant dev_err()

[Ruan Jinjie]

There is no need to call the dev_err() function directly to print a custom
message when handling an error from platform_get_irq() function as
it is going to display an appropriate error message in case of a failure.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
 drivers/i2c/busses/i2c-s3c2410.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 28f0e5c64f32..703a43446eaa 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1076,7 +1076,6 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
 	if (!(i2c->quirks & QUIRK_POLL)) {
 		i2c->irq = ret = platform_get_irq(pdev, 0);
 		if (ret < 0) {
-			dev_err(&pdev->dev, "cannot find IRQ\n");
 			clk_unprepare(i2c->clk);
 			return ret;
 		}
-- 
2.34.1

Re: [PATCH -next] i2c: s3c2410: Remove redundant dev_err()

[Andi Shyti]

Hi

On Wed, 26 Jul 2023 17:42:26 +0000, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as
> it is going to display an appropriate error message in case of a failure.
> 
> 

Applied to i2c/andi-for-next on

https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git

Please note that this patch may still undergo further evaluation
and the final decision will be made in collaboration with
Wolfram.

Thank you,
Andi

Patches applied
===============
[1/1] i2c: s3c2410: Remove redundant dev_err()
      commit: c0e109161aad5d543145d79921d1a577c8fa2eee

Re: [PATCH -next] i2c: s3c2410: Remove redundant dev_err()

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

On Wed, Aug 02, 2023 at 10:10:35PM +0200, Andi Shyti wrote:
> Hi
> 
> On Wed, 26 Jul 2023 17:42:26 +0000, Ruan Jinjie wrote:
> > There is no need to call the dev_err() function directly to print a custom
> > message when handling an error from platform_get_irq() function as
> > it is going to display an appropriate error message in case of a failure.
> > 
> > 

Applied to for-next (via Andi's branch), thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]