* [PATCH -next] i2c: s3c2410: Remove redundant dev_err()
@ 2023-07-26 17:42 Ruan Jinjie
2023-07-26 14:46 ` Andi Shyti
2023-08-02 20:10 ` Andi Shyti
0 siblings, 2 replies; 4+ messages in thread
From: Ruan Jinjie @ 2023-07-26 17:42 UTC (permalink / raw)
To: krzysztof.kozlowski, alim.akhtar, andi.shyti, linux-arm-kernel,
linux-kernel, linux-samsung-soc, linux-i2c
Cc: ruanjinjie
There is no need to call the dev_err() function directly to print a custom
message when handling an error from platform_get_irq() function as
it is going to display an appropriate error message in case of a failure.
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
drivers/i2c/busses/i2c-s3c2410.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 28f0e5c64f32..703a43446eaa 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1076,7 +1076,6 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
if (!(i2c->quirks & QUIRK_POLL)) {
i2c->irq = ret = platform_get_irq(pdev, 0);
if (ret < 0) {
- dev_err(&pdev->dev, "cannot find IRQ\n");
clk_unprepare(i2c->clk);
return ret;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] i2c: s3c2410: Remove redundant dev_err()
2023-07-26 17:42 [PATCH -next] i2c: s3c2410: Remove redundant dev_err() Ruan Jinjie
@ 2023-07-26 14:46 ` Andi Shyti
2023-08-02 20:10 ` Andi Shyti
1 sibling, 0 replies; 4+ messages in thread
From: Andi Shyti @ 2023-07-26 14:46 UTC (permalink / raw)
To: Ruan Jinjie
Cc: krzysztof.kozlowski, alim.akhtar, linux-arm-kernel, linux-kernel,
linux-samsung-soc, linux-i2c
Hi Ruan,
On Wed, Jul 26, 2023 at 05:42:26PM +0000, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as
> it is going to display an appropriate error message in case of a failure.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Correct!
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Andi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] i2c: s3c2410: Remove redundant dev_err()
2023-07-26 17:42 [PATCH -next] i2c: s3c2410: Remove redundant dev_err() Ruan Jinjie
2023-07-26 14:46 ` Andi Shyti
@ 2023-08-02 20:10 ` Andi Shyti
2023-08-14 15:05 ` Wolfram Sang
1 sibling, 1 reply; 4+ messages in thread
From: Andi Shyti @ 2023-08-02 20:10 UTC (permalink / raw)
To: krzysztof.kozlowski, alim.akhtar, linux-arm-kernel, linux-kernel,
linux-samsung-soc, linux-i2c, Ruan Jinjie
Cc: Andi Shyti
Hi
On Wed, 26 Jul 2023 17:42:26 +0000, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as
> it is going to display an appropriate error message in case of a failure.
>
>
Applied to i2c/andi-for-next on
https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git
Please note that this patch may still undergo further evaluation
and the final decision will be made in collaboration with
Wolfram.
Thank you,
Andi
Patches applied
===============
[1/1] i2c: s3c2410: Remove redundant dev_err()
commit: c0e109161aad5d543145d79921d1a577c8fa2eee
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] i2c: s3c2410: Remove redundant dev_err()
2023-08-02 20:10 ` Andi Shyti
@ 2023-08-14 15:05 ` Wolfram Sang
0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2023-08-14 15:05 UTC (permalink / raw)
To: Andi Shyti
Cc: krzysztof.kozlowski, alim.akhtar, linux-arm-kernel, linux-kernel,
linux-samsung-soc, linux-i2c, Ruan Jinjie
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
On Wed, Aug 02, 2023 at 10:10:35PM +0200, Andi Shyti wrote:
> Hi
>
> On Wed, 26 Jul 2023 17:42:26 +0000, Ruan Jinjie wrote:
> > There is no need to call the dev_err() function directly to print a custom
> > message when handling an error from platform_get_irq() function as
> > it is going to display an appropriate error message in case of a failure.
> >
> >
Applied to for-next (via Andi's branch), thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-14 15:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-26 17:42 [PATCH -next] i2c: s3c2410: Remove redundant dev_err() Ruan Jinjie
2023-07-26 14:46 ` Andi Shyti
2023-08-02 20:10 ` Andi Shyti
2023-08-14 15:05 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox