From: Arnd Bergmann <arnd@arndb.de>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org,
discuss@x86-64.org, sparclinux@vger.kernel.org,
linuxppc64-dev@ozlabs.org, linux-m68k@vger.kernel.org,
linux-sh@m17n.org, linux-arm-kernel@lists.arm.linux.org.uk,
parisc-linux@parisc-linux.org, linux-ia64@vger.kernel.org,
linux-390@vm.marist.edu, linux-mips@linux-mips.org
Subject: Re: [PATCH] Add key management syscalls to non-i386 archs
Date: Wed, 20 Oct 2004 17:08:17 +0000 [thread overview]
Message-ID: <200410201908.18273.arnd@arndb.de> (raw)
In-Reply-To: <3506.1098283455@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1644 bytes --]
On Middeweken 20 Oktober 2004 16:44, David Howells wrote:
> diff -uNrp linux-2.6.9-bk4/arch/s390/kernel/compat_wrapper.S linux-2.6.9-bk4-keys/arch/s390/kernel/compat_wrapper.S
> --- linux-2.6.9-bk4/arch/s390/kernel/compat_wrapper.S 2004-06-18 13:43:49.000000000 +0100
> +++ linux-2.6.9-bk4-keys/arch/s390/kernel/compat_wrapper.S 2004-10-20 15:08:00.071403677 +0100
> @@ -1406,3 +1406,29 @@ compat_sys_mq_getsetattr_wrapper:
> llgtr %r3,%r3 # struct compat_mq_attr *
> llgtr %r4,%r4 # struct compat_mq_attr *
> jg compat_sys_mq_getsetattr
> +
> + .globl sys32_add_key_wrapper
> +sys32_add_key_wrapper:
> + lgfr %r2,%r2 # const char *
> + llgfr %r3,%r3 # const char *
> + llgfr %r4,%r4 # const void *
> + llgfr %r5,%r5 # size_t
> + llgfr %r6,%r6 # key_serial_t
> + jg sys_add_key # branch to system call
> +
> + .globl sys32_request_key_wrapper
> +sys32_request_key_wrapper:
> + lgfr %r2,%r2 # const char *
> + llgfr %r3,%r3 # const char *
> + llgfr %r4,%r4 # const char *
> + llgfr %r5,%r5 # key_serial_t
> + jg sys_request_key # branch to system call
> +
> + .globl sys32_keyctl_wrapper
> +sys32_keyctl_wrapper:
> + lgfr %r2,%r2 # int
> + llgfr %r3,%r3 # unsigned long
> + llgfr %r4,%r4 # unsigned long
> + llgfr %r5,%r5 # unsigned long
> + llgfr %r6,%r6 # unsigned long
> + jg sys_keyctl # branch to system call
The comments don't match with the code. Please use the correct
lgfr/llgfr/llgtr opcodes for signed/unsigned/pointer extension.
Note that for keyctl_wrapper, the actual conversion is not static
but depends on the value of %r2. You probably want to code that
conversion in C.
Arnd <><
[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-10-20 17:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 14:44 [PATCH] Add key management syscalls to non-i386 archs David Howells
2004-10-20 15:29 ` Christoph Hellwig
2004-10-20 17:50 ` Andrew Morton
2004-10-20 18:18 ` Christoph Hellwig
2004-10-20 15:49 ` [parisc-linux] " Matthew Wilcox
2004-10-20 16:16 ` David Howells
2004-10-20 17:08 ` Arnd Bergmann [this message]
2004-10-20 22:01 ` David S. Miller
2004-10-20 22:56 ` [discuss] " Andi Kleen
2004-10-20 23:04 ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 David S. Miller
2004-10-20 23:25 ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs Andi Kleen
2004-10-20 23:41 ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 David S. Miller
2004-10-21 0:10 ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs Andi Kleen
2004-10-21 8:03 ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 Geert Uytterhoeven
2004-10-21 1:55 ` Benjamin Herrenschmidt
2004-10-21 8:47 ` [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs Jan-Benedict Glaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410201908.18273.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=discuss@x86-64.org \
--cc=linux-390@vm.marist.edu \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-sh@m17n.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=parisc-linux@parisc-linux.org \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox