From: Andi Kleen <ak@suse.de>
To: Christoph Hellwig <hch@infradead.org>,
Jack Steiner <steiner@sgi.com>, Andreas Schwab <schwab@suse.de>,
Takayoshi Kochi <t-kochi@bq.jp.nec.com>,
ak@suse.de, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Externalize SLIT table
Date: Sat, 06 Nov 2004 12:48:38 +0000 [thread overview]
Message-ID: <20041106124838.GA16434@wotan.suse.de> (raw)
In-Reply-To: <20041106115029.GB23305@infradead.org>
On Sat, Nov 06, 2004 at 11:50:29AM +0000, Christoph Hellwig wrote:
> On Fri, Nov 05, 2004 at 10:44:49AM -0600, Jack Steiner wrote:
> > > > + for (i = 0; i < numnodes; i++)
> > > > + len += sprintf(buf + len, "%s%d", i ? " " : "", node_distance(nid, i));
> > >
> > > Can this overflow the space allocated for buf?
> >
> >
> > Good point. I think we are ok for now. AFAIK, the largest cpu count
> > currently supported is 512. That gives a max string of 2k (max of 3
> > digits + space per cpu).
>
> I always wondered why sysfs doesn't use the seq_file interface that makes
> life easier in the rest of them kernel.
Most fields only output a single number, and seq_file would be
extreme overkill for that.
-Andi
next prev parent reply other threads:[~2004-11-06 12:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-03 20:56 Externalize SLIT table Jack Steiner
2004-11-04 1:59 ` Takayoshi Kochi
2004-11-04 4:07 ` Andi Kleen
2004-11-04 4:57 ` Takayoshi Kochi
2004-11-04 6:37 ` Andi Kleen
2004-11-05 16:08 ` Jack Steiner
2004-11-05 16:26 ` Andreas Schwab
2004-11-05 16:44 ` Jack Steiner
2004-11-06 11:50 ` Christoph Hellwig
2004-11-06 12:48 ` Andi Kleen [this message]
2004-11-06 13:07 ` Christoph Hellwig
2004-11-05 17:13 ` Erich Focht
2004-11-05 19:13 ` Jack Steiner
2004-11-09 19:23 ` Matthew Dobson
2004-11-04 14:13 ` Jack Steiner
2004-11-04 14:29 ` Andi Kleen
2004-11-04 15:31 ` Erich Focht
2004-11-04 17:04 ` Andi Kleen
2004-11-04 19:36 ` Jack Steiner
2004-11-09 19:45 ` Matthew Dobson
2004-11-09 19:43 ` Matthew Dobson
2004-11-09 20:34 ` Mark Goodwin
2004-11-09 22:00 ` Jesse Barnes
2004-11-09 23:58 ` Matthew Dobson
2004-11-10 5:05 ` Mark Goodwin
2004-11-10 18:45 ` Erich Focht
2004-11-10 22:09 ` Matthew Dobson
2004-11-18 16:39 ` Jack Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041106124838.GA16434@wotan.suse.de \
--to=ak@suse.de \
--cc=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@suse.de \
--cc=steiner@sgi.com \
--cc=t-kochi@bq.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox