* [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0
@ 2022-10-06 5:17 Christophe Leroy
2022-10-06 5:45 ` Damien Le Moal
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Christophe Leroy @ 2022-10-06 5:17 UTC (permalink / raw)
To: Sergey Shtylyov, Damien Le Moal; +Cc: Christophe Leroy, linux-kernel, linux-ide
NO_IRQ is used to check the return of irq_of_parse_and_map().
On some architecture NO_IRQ is 0, on other architectures it is -1.
irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
So use 0 instead of using NO_IRQ.
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
drivers/ata/pata_mpc52xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
index 6559b606736d..3ebd6522a1fd 100644
--- a/drivers/ata/pata_mpc52xx.c
+++ b/drivers/ata/pata_mpc52xx.c
@@ -731,7 +731,7 @@ static int mpc52xx_ata_probe(struct platform_device *op)
udma_mask = ATA_UDMA2 & ((1 << (*prop + 1)) - 1);
ata_irq = irq_of_parse_and_map(op->dev.of_node, 0);
- if (ata_irq == NO_IRQ) {
+ if (!ata_irq) {
dev_err(&op->dev, "error mapping irq\n");
return -EINVAL;
}
--
2.37.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0
2022-10-06 5:17 [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0 Christophe Leroy
@ 2022-10-06 5:45 ` Damien Le Moal
2022-10-06 5:49 ` Christophe Leroy
2022-10-06 8:37 ` Sergey Shtylyov
2022-10-17 2:43 ` Damien Le Moal
2 siblings, 1 reply; 8+ messages in thread
From: Damien Le Moal @ 2022-10-06 5:45 UTC (permalink / raw)
To: Christophe Leroy, Sergey Shtylyov; +Cc: linux-kernel, linux-ide
On 10/6/22 14:17, Christophe Leroy wrote:
> NO_IRQ is used to check the return of irq_of_parse_and_map().
>
> On some architecture NO_IRQ is 0, on other architectures it is -1.
>
> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>
> So use 0 instead of using NO_IRQ.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Doesn't this need fixes and cc:stable tags ?
> ---
> drivers/ata/pata_mpc52xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
> index 6559b606736d..3ebd6522a1fd 100644
> --- a/drivers/ata/pata_mpc52xx.c
> +++ b/drivers/ata/pata_mpc52xx.c
> @@ -731,7 +731,7 @@ static int mpc52xx_ata_probe(struct platform_device *op)
> udma_mask = ATA_UDMA2 & ((1 << (*prop + 1)) - 1);
>
> ata_irq = irq_of_parse_and_map(op->dev.of_node, 0);
> - if (ata_irq == NO_IRQ) {
> + if (!ata_irq) {
> dev_err(&op->dev, "error mapping irq\n");
> return -EINVAL;
> }
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0
2022-10-06 5:45 ` Damien Le Moal
@ 2022-10-06 5:49 ` Christophe Leroy
2022-10-06 6:30 ` Damien Le Moal
0 siblings, 1 reply; 8+ messages in thread
From: Christophe Leroy @ 2022-10-06 5:49 UTC (permalink / raw)
To: Damien Le Moal, Sergey Shtylyov
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Le 06/10/2022 à 07:45, Damien Le Moal a écrit :
> On 10/6/22 14:17, Christophe Leroy wrote:
>> NO_IRQ is used to check the return of irq_of_parse_and_map().
>>
>> On some architecture NO_IRQ is 0, on other architectures it is -1.
>>
>> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>>
>> So use 0 instead of using NO_IRQ.
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>
> Doesn't this need fixes and cc:stable tags ?
I don't think so, because the only user of this driver is powerpc and
powerpc has NO_IRQ set to 0.
I'm sending this because I was to remove NO_IRQ in powerpc in a second step.
>
>> ---
>> drivers/ata/pata_mpc52xx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
>> index 6559b606736d..3ebd6522a1fd 100644
>> --- a/drivers/ata/pata_mpc52xx.c
>> +++ b/drivers/ata/pata_mpc52xx.c
>> @@ -731,7 +731,7 @@ static int mpc52xx_ata_probe(struct platform_device *op)
>> udma_mask = ATA_UDMA2 & ((1 << (*prop + 1)) - 1);
>>
>> ata_irq = irq_of_parse_and_map(op->dev.of_node, 0);
>> - if (ata_irq == NO_IRQ) {
>> + if (!ata_irq) {
>> dev_err(&op->dev, "error mapping irq\n");
>> return -EINVAL;
>> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0
2022-10-06 5:49 ` Christophe Leroy
@ 2022-10-06 6:30 ` Damien Le Moal
2022-10-06 8:19 ` Christophe Leroy
0 siblings, 1 reply; 8+ messages in thread
From: Damien Le Moal @ 2022-10-06 6:30 UTC (permalink / raw)
To: Christophe Leroy, Sergey Shtylyov
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
On 10/6/22 14:49, Christophe Leroy wrote:
>
>
> Le 06/10/2022 à 07:45, Damien Le Moal a écrit :
>> On 10/6/22 14:17, Christophe Leroy wrote:
>>> NO_IRQ is used to check the return of irq_of_parse_and_map().
>>>
>>> On some architecture NO_IRQ is 0, on other architectures it is -1.
>>>
>>> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>>>
>>> So use 0 instead of using NO_IRQ.
>>>
>>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>>
>> Doesn't this need fixes and cc:stable tags ?
>
> I don't think so, because the only user of this driver is powerpc and
> powerpc has NO_IRQ set to 0.
>
> I'm sending this because I was to remove NO_IRQ in powerpc in a second step.
OK. Got it. So queuing this for 6.2 is OK ? Or do you prefer seeing this
as a "fix" in 6.1 ?
>
>>
>>> ---
>>> drivers/ata/pata_mpc52xx.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
>>> index 6559b606736d..3ebd6522a1fd 100644
>>> --- a/drivers/ata/pata_mpc52xx.c
>>> +++ b/drivers/ata/pata_mpc52xx.c
>>> @@ -731,7 +731,7 @@ static int mpc52xx_ata_probe(struct platform_device *op)
>>> udma_mask = ATA_UDMA2 & ((1 << (*prop + 1)) - 1);
>>>
>>> ata_irq = irq_of_parse_and_map(op->dev.of_node, 0);
>>> - if (ata_irq == NO_IRQ) {
>>> + if (!ata_irq) {
>>> dev_err(&op->dev, "error mapping irq\n");
>>> return -EINVAL;
>>> }
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0
2022-10-06 6:30 ` Damien Le Moal
@ 2022-10-06 8:19 ` Christophe Leroy
0 siblings, 0 replies; 8+ messages in thread
From: Christophe Leroy @ 2022-10-06 8:19 UTC (permalink / raw)
To: Damien Le Moal, Sergey Shtylyov
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Le 06/10/2022 à 08:30, Damien Le Moal a écrit :
> On 10/6/22 14:49, Christophe Leroy wrote:
>>
>>
>> Le 06/10/2022 à 07:45, Damien Le Moal a écrit :
>>> On 10/6/22 14:17, Christophe Leroy wrote:
>>>> NO_IRQ is used to check the return of irq_of_parse_and_map().
>>>>
>>>> On some architecture NO_IRQ is 0, on other architectures it is -1.
>>>>
>>>> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>>>>
>>>> So use 0 instead of using NO_IRQ.
>>>>
>>>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>>>
>>> Doesn't this need fixes and cc:stable tags ?
>>
>> I don't think so, because the only user of this driver is powerpc and
>> powerpc has NO_IRQ set to 0.
>>
>> I'm sending this because I was to remove NO_IRQ in powerpc in a second step.
>
> OK. Got it. So queuing this for 6.2 is OK ? Or do you prefer seeing this
> as a "fix" in 6.1 ?
Yes 6.2 is fine.
Thanks
Christophe
>
>>
>>>
>>>> ---
>>>> drivers/ata/pata_mpc52xx.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
>>>> index 6559b606736d..3ebd6522a1fd 100644
>>>> --- a/drivers/ata/pata_mpc52xx.c
>>>> +++ b/drivers/ata/pata_mpc52xx.c
>>>> @@ -731,7 +731,7 @@ static int mpc52xx_ata_probe(struct platform_device *op)
>>>> udma_mask = ATA_UDMA2 & ((1 << (*prop + 1)) - 1);
>>>>
>>>> ata_irq = irq_of_parse_and_map(op->dev.of_node, 0);
>>>> - if (ata_irq == NO_IRQ) {
>>>> + if (!ata_irq) {
>>>> dev_err(&op->dev, "error mapping irq\n");
>>>> return -EINVAL;
>>>> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0
2022-10-06 5:17 [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0 Christophe Leroy
2022-10-06 5:45 ` Damien Le Moal
@ 2022-10-06 8:37 ` Sergey Shtylyov
2022-10-06 8:43 ` Damien Le Moal
2022-10-17 2:43 ` Damien Le Moal
2 siblings, 1 reply; 8+ messages in thread
From: Sergey Shtylyov @ 2022-10-06 8:37 UTC (permalink / raw)
To: Christophe Leroy, Damien Le Moal; +Cc: linux-kernel, linux-ide
Hello!
Perhaps s/by/with/ in the subject?
On 10/6/22 8:17 AM, Christophe Leroy wrote:
> NO_IRQ is used to check the return of irq_of_parse_and_map().
>
> On some architecture NO_IRQ is 0, on other architectures it is -1.
>
> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>
> So use 0 instead of using NO_IRQ.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0
2022-10-06 8:37 ` Sergey Shtylyov
@ 2022-10-06 8:43 ` Damien Le Moal
0 siblings, 0 replies; 8+ messages in thread
From: Damien Le Moal @ 2022-10-06 8:43 UTC (permalink / raw)
To: Sergey Shtylyov, Christophe Leroy; +Cc: linux-kernel, linux-ide
On 10/6/22 17:37, Sergey Shtylyov wrote:
> Hello!
>
> Perhaps s/by/with/ in the subject?
I can fix that when applying.
>
> On 10/6/22 8:17 AM, Christophe Leroy wrote:
>
>> NO_IRQ is used to check the return of irq_of_parse_and_map().
>>
>> On some architecture NO_IRQ is 0, on other architectures it is -1.
>>
>> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>>
>> So use 0 instead of using NO_IRQ.
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>
> [...]
>
> MBR, Sergey
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0
2022-10-06 5:17 [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0 Christophe Leroy
2022-10-06 5:45 ` Damien Le Moal
2022-10-06 8:37 ` Sergey Shtylyov
@ 2022-10-17 2:43 ` Damien Le Moal
2 siblings, 0 replies; 8+ messages in thread
From: Damien Le Moal @ 2022-10-17 2:43 UTC (permalink / raw)
To: Christophe Leroy, Sergey Shtylyov; +Cc: linux-kernel, linux-ide
On 10/6/22 14:17, Christophe Leroy wrote:
> NO_IRQ is used to check the return of irq_of_parse_and_map().
>
> On some architecture NO_IRQ is 0, on other architectures it is -1.
>
> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>
> So use 0 instead of using NO_IRQ.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> drivers/ata/pata_mpc52xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
> index 6559b606736d..3ebd6522a1fd 100644
> --- a/drivers/ata/pata_mpc52xx.c
> +++ b/drivers/ata/pata_mpc52xx.c
> @@ -731,7 +731,7 @@ static int mpc52xx_ata_probe(struct platform_device *op)
> udma_mask = ATA_UDMA2 & ((1 << (*prop + 1)) - 1);
>
> ata_irq = irq_of_parse_and_map(op->dev.of_node, 0);
> - if (ata_irq == NO_IRQ) {
> + if (!ata_irq) {
> dev_err(&op->dev, "error mapping irq\n");
> return -EINVAL;
> }
Applied to for-6.2. Thanks !
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-10-17 2:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-06 5:17 [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0 Christophe Leroy
2022-10-06 5:45 ` Damien Le Moal
2022-10-06 5:49 ` Christophe Leroy
2022-10-06 6:30 ` Damien Le Moal
2022-10-06 8:19 ` Christophe Leroy
2022-10-06 8:37 ` Sergey Shtylyov
2022-10-06 8:43 ` Damien Le Moal
2022-10-17 2:43 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox