Re: SATA ATAPI work in progress

[Pat LaVarre <p.lavarre@ieee.org>]

> > +static unsigned int atapi_xlat(struct ata_queued_cmd *qc, u8
> *scsicmd)
> > +{
> > +     int bcl = (8 * 0x400); /* PIO "byte count limit" */
> 
> Make this a more obvious "8 * 1024".
> 
> For the sake of correctness, I prefer to call this "DRQ block size" 
> rather than the more ambigous "byte count limit".
> 
> This is important because some AHCI SATA controllers can only transfer
> a _single_ DRQ block per disk transaction.  In anticipation of the
> demise of PIO, no doubt :)

Perhaps I should check:

Are we agreed that this bcl is the max permissible byte count for a PIO
DRQ, distinct from the actual byte count of a PIO DRQ?

For example, if our limit is x800, then the t13.org texts let the device
reply with x200 + x600 + x800 + x400 ...  They allow any distribution of
addends, so long as no single INTRQ asks for more than the limit we set.

ATAPI often, but not reliably, implies x800 bytes/lba = 2 KiB/lba, by
way of implying but not requiring PDT x05 MMC = DVD/CD.

Pat LaVarre