From: Pat LaVarre <p.lavarre@ieee.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: SATA ATAPI work in progress
Date: 15 May 2004 07:49:38 -0600 [thread overview]
Message-ID: <1084628978.5082.7.camel@patibmrh9> (raw)
In-Reply-To: <1084626376.3079.8.camel@patibmrh9>
[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]
> I doubt I can use this patch as is. I believe, because I assembled my
> drive from components myself, its op xA1 Identify data has not changed,
> so I will see a misleading 0 False at:
>
> #define ata_id_use_dmadir(dev) ((dev)->id[62] & (1 << 15))
Theory confirmed!
> ...
Specifically I saw:
kernel: ata_dump_id: 88==0x203f 93==0x404f
kernel: Assertion failed! dev->class == ATA_DEV_ATA,drivers/scsi/libata-core.c,ata_dev_parse_strings,line=867
kernel: ata2: dev 0 ATA ata_id_use_dmadir
kernel: ata2: dev 0 ATA 'word' 62 = x0000
kernel: ata2: dev 0 ATAPI, max UDMA/100
kernel: ata_dev_identify: EXIT, drv_stat = 0x50
reported by the following experimental pel.patch.7x, applied after
patch.[1234567] from Jeff G.
Pat LaVarre
--- o/drivers/scsi/libata-core.c 2004-05-15 07:31:49.000000000 -0600
+++ linux-2.6.6-bk1/drivers/scsi/libata-core.c 2004-05-15 07:39:24.737046832 -0600
@@ -1168,8 +1168,16 @@ retry:
if (ata_id_is_ata(dev)) /* sanity check */
goto err_out_nosup;
+ printk(KERN_INFO "ata%u: dev %u ATA ata_id_use_dmadir\n",
+ ap->id, device);
if (ata_id_use_dmadir(dev))
dev->flags |= ATA_DFLAG_DMADIR;
+ else {
+ dev->flags |= ATA_DFLAG_DMADIR;
+ printk(KERN_INFO "ata%u: dev %u ATA"
+ "'word' 62 = x%04X\n",
+ ap->id, device, (dev)->id[62]);
+ }
/* see if 16-byte commands supported */
tmp = dev->id[0] & 0x3;
[-- Attachment #2: pel.patch.7x --]
[-- Type: text/x-troff-man, Size: 633 bytes --]
--- o/drivers/scsi/libata-core.c 2004-05-15 07:31:49.000000000 -0600
+++ linux-2.6.6-bk1/drivers/scsi/libata-core.c 2004-05-15 07:39:24.737046832 -0600
@@ -1168,8 +1168,16 @@ retry:
if (ata_id_is_ata(dev)) /* sanity check */
goto err_out_nosup;
+ printk(KERN_INFO "ata%u: dev %u ATA ata_id_use_dmadir\n",
+ ap->id, device);
if (ata_id_use_dmadir(dev))
dev->flags |= ATA_DFLAG_DMADIR;
+ else {
+ dev->flags |= ATA_DFLAG_DMADIR;
+ printk(KERN_INFO "ata%u: dev %u ATA"
+ "'word' 62 = x%04X\n",
+ ap->id, device, (dev)->id[62]);
+ }
/* see if 16-byte commands supported */
tmp = dev->id[0] & 0x3;
next prev parent reply other threads:[~2004-05-15 13:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-12 20:20 SATA ATAPI work in progress Pat LaVarre
2004-05-12 20:40 ` Jeff Garzik
2004-05-12 23:14 ` Pat LaVarre
2004-05-13 15:07 ` Pat LaVarre
2004-05-13 20:56 ` Jeff Garzik
2004-05-13 21:16 ` Jeff Garzik
2004-05-13 21:25 ` Jeff Garzik
2004-05-13 21:36 ` Pat LaVarre
2004-05-13 21:44 ` Jeff Garzik
2004-05-13 21:49 ` Jeff Garzik
2004-05-14 18:23 ` Pat LaVarre
2004-05-14 18:55 ` Jeff Garzik
2004-05-14 19:37 ` when limited to a single DRQ block per disk transaction Pat LaVarre
2004-05-14 19:50 ` Jeff Garzik
2004-05-14 20:12 ` Pat LaVarre
2004-05-14 23:47 ` SATA ATAPI work in progress Pat LaVarre
2004-05-15 0:02 ` Pat LaVarre
2004-05-15 0:38 ` Jeff Garzik
2004-05-15 13:06 ` Pat LaVarre
2004-05-15 13:49 ` Pat LaVarre [this message]
2004-05-15 15:27 ` Jeff Garzik
2004-05-15 15:49 ` Pat LaVarre
2004-05-15 15:56 ` Pat LaVarre
2004-05-15 16:04 ` Pat LaVarre
2004-05-15 16:32 ` Jeff Garzik
2004-05-15 16:43 ` Pat LaVarre
2004-05-15 16:50 ` Pat LaVarre
2004-05-15 16:30 ` Jeff Garzik
2004-05-15 0:46 ` [PATCH] " Jeff Garzik
2004-05-15 13:08 ` Pat LaVarre
2004-05-15 13:10 ` Pat LaVarre
2004-05-15 14:13 ` Pat LaVarre
2004-05-14 18:28 ` Pat LaVarre
2004-05-14 18:38 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1084628978.5082.7.camel@patibmrh9 \
--to=p.lavarre@ieee.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox