Re: SATA ATAPI work in progress

[Pat LaVarre <p.lavarre@ieee.org>]

> > kernel: ata_scsi_dump_cdb: CDB (2:0,0,0) 00 00 00 00 00 00 00 00 00
> > kernel: ata_scsi_translate: ENTER
> > kernel: ata2(0): empty request buffer
> > kernel: ata_scsi_badcmd: ENTER
> > kernel: ata_scsi_translate: EXIT - badcmd
> 
> TEST UNIT READY.  We probably just delete the following check, which 
> appears to be bogus now.  I can't remember why I put this in here...
> 
>          if (unlikely(cmd->request_bufflen < 1)) {
>                  printk(KERN_WARNING "ata%u(%u): empty request buffer\n",
>                         ap->id, dev->devno);
>                  goto err_out;
>          }

Independently I tried omitting that test.  With that test gone, my
kernel does not crash, but still the open (and thereafter modprobe -r)
does not complete:

kernel: ata_scsi_dump_cdb: CDB (2:0,0,0) 00 00 00 00 00 00 00 00 00
kernel: ata_scsi_translate: ENTER
kernel: ata_dev_select: ENTER, ata2: device 0, wait 1
kernel: ata_tf_load_pio: feat 0x0 nsect 0x0 lba 0x0 0x0 0x20
kernel: ata_tf_load_pio: device 0xA0
kernel: ata_exec_command_pio: ata2: cmd 0xA0
kernel: ata_scsi_translate: EXIT
kernel: atapi_packet_task: busy wait
kernel: atapi_packet_task: send cdb
kernel: ata_scsi_error: ENTER
kernel: ata_eng_timeout: ENTER
kernel: ata2: unknown timeout, cmd 0xa0 stat 0x51
kernel: ata_eng_timeout: EXIT
kernel: ata_scsi_error: EXIT
kernel: ata_scsi_dump_cdb: CDB (2:0,0,0) 00 00 00 00 00 00 00 00 00
kernel: ata_scsi_translate: ENTER
kernel: ata_dev_select: ENTER, ata2: device 0, wait 1
kernel: ata_tf_load_pio: feat 0x0 nsect 0x0 lba 0x0 0x0 0x20
kernel: ata_tf_load_pio: device 0xA0
kernel: ata_exec_command_pio: ata2: cmd 0xA0
kernel: ata_scsi_translate: EXIT
kernel: atapi_packet_task: busy wait
kernel: atapi_packet_task: send cdb

In my ignorance, I'm now trying leaving that test commented out but then
also trying to teach atapi_xlat to cope if:

((cmd->sc_data_direction != SCSI_DATA_NONE) &&
	(cmd->request_bufflen < 1))

Soon I will give up for this day, sorry to say, real life intrudes.

Pat LaVarre