From: Pat LaVarre <p.lavarre@ieee.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: SATA ATAPI work in progress
Date: 14 May 2004 18:02:43 -0600 [thread overview]
Message-ID: <1084579362.3271.5.camel@patibmrh9> (raw)
In-Reply-To: <1084578453.5343.26.camel@patibmrh9>
[-- Attachment #1: Type: text/plain, Size: 2586 bytes --]
> > Applying patch.[12345] in order to linux-2.6.6-bk1/ here yielded:
> > ...
> > kernel: ata_tf_load_pio: feat 0x1 nsect 0x0 lba 0x0 0x0 0x0
> > kernel: ata_tf_load_pio: device 0xA0
> > kernel: ata_exec_command_pio: ata2: cmd 0xA0
> > kernel: ata_scsi_translate: EXIT
> > kernel: atapi_packet_task: busy wait
> > kernel: atapi_packet_task: send cdb
> > kernel: ata_scsi_error: ENTER
> > kernel: ata_eng_timeout: ENTER
> > kernel: ata2: unknown timeout, cmd 0xa0 stat 0xd0
> > ...
> > Next I will try
> > o x1F1 Features = x05 Dma In and x01 Dma Out because ...
Results follow. Much improved now, yes?
Pat LaVarre
kernel: ata_scsi_dump_cdb: CDB (2:0,0,0) 12 00 00 00 24 00 00 00 46
kernel: ata_scsi_translate: ENTER
kernel: ata_sg_setup_one: mapped buffer of 36 bytes for read
kernel: ata_fill_sg: PRD[0] = (0x49EE54, 0x24)
kernel: ata_dev_select: ENTER, ata2: device 0, wait 1
kernel: ata_tf_load_pio: feat 0x5 nsect 0x0 lba 0x0 0x0 0x0
kernel: ata_tf_load_pio: device 0xA0
kernel: ata_exec_command_pio: ata2: cmd 0xA0
kernel: ata_scsi_translate: EXIT
kernel: atapi_packet_task: busy wait
kernel: atapi_packet_task: send cdb
kernel: irq 18: nobody cared!
kernel: Call Trace:
kernel: [<c0107f83>] __report_bad_irq+0x2a/0x8b
kernel: [<c010806d>] note_interrupt+0x6f/0x9f
kernel: [<c01083a1>] do_IRQ+0x175/0x1a6
kernel: [<c0103aae>] default_idle+0x0/0x2d
kernel: [<c01065c0>] common_interrupt+0x18/0x20
kernel: [<c0103aae>] default_idle+0x0/0x2d
kernel: [<c0103ad8>] default_idle+0x2a/0x2d
kernel: [<c0103b4c>] cpu_idle+0x37/0x40
kernel: [<c044289c>] start_kernel+0x1b1/0x202
kernel: [<c0442428>] unknown_bootoption+0x0/0x129
kernel:
kernel: handlers:
kernel: [<df9675a0>] (ata_interrupt+0x0/0x1a5 [libata])
kernel: Disabling IRQ #18
kernel: ata_scsi_error: ENTER
kernel: ata_eng_timeout: ENTER
kernel: ata2: unknown timeout, cmd 0xa0 stat 0x50
kernel: ata_sg_clean: unmapping 1 sg elements
kernel: ata_eng_timeout: EXIT
kernel: ata_scsi_error: EXIT
kernel: ata_scsi_dump_cdb: CDB (2:0,0,0) 12 00 00 00 c0 00 00 00 46
diff -Nurp o/drivers/scsi linux-2.6.6-bk1/drivers/scsi/libata-scsi.c
--- o/drivers/scsi/libata-scsi.c 2004-05-14 18:00:22.472765072 -0600
+++ linux-2.6.6-bk1/drivers/scsi/libata-scsi.c 2004-05-14 17:51:38.000000000 -0600
@@ -920,6 +920,9 @@ static unsigned int atapi_xlat(struct at
qc->flags |= ATA_QCFLAG_SG; /* data is present; dma-map it */
qc->tf.protocol = ATA_PROT_ATAPI_DMA;
qc->tf.feature |= ATAPI_PKT_DMA;
+ if (cmd->sc_data_direction != SCSI_DATA_WRITE) {
+ qc->tf.feature |= 0x04; /* Silicon Image DMADIR */
+ }
}
return 0;
[-- Attachment #2: pel.patch.6 --]
[-- Type: text/x-patch, Size: 554 bytes --]
diff -Nurp o/drivers/scsi linux-2.6.6-bk1/drivers/scsi/libata-scsi.c
--- o/drivers/scsi/libata-scsi.c 2004-05-14 18:00:22.472765072 -0600
+++ linux-2.6.6-bk1/drivers/scsi/libata-scsi.c 2004-05-14 17:51:38.000000000 -0600
@@ -920,6 +920,9 @@ static unsigned int atapi_xlat(struct at
qc->flags |= ATA_QCFLAG_SG; /* data is present; dma-map it */
qc->tf.protocol = ATA_PROT_ATAPI_DMA;
qc->tf.feature |= ATAPI_PKT_DMA;
+ if (cmd->sc_data_direction != SCSI_DATA_WRITE) {
+ qc->tf.feature |= 0x04; /* Silicon Image DMADIR */
+ }
}
return 0;
next prev parent reply other threads:[~2004-05-15 0:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-12 20:20 SATA ATAPI work in progress Pat LaVarre
2004-05-12 20:40 ` Jeff Garzik
2004-05-12 23:14 ` Pat LaVarre
2004-05-13 15:07 ` Pat LaVarre
2004-05-13 20:56 ` Jeff Garzik
2004-05-13 21:16 ` Jeff Garzik
2004-05-13 21:25 ` Jeff Garzik
2004-05-13 21:36 ` Pat LaVarre
2004-05-13 21:44 ` Jeff Garzik
2004-05-13 21:49 ` Jeff Garzik
2004-05-14 18:23 ` Pat LaVarre
2004-05-14 18:55 ` Jeff Garzik
2004-05-14 19:37 ` when limited to a single DRQ block per disk transaction Pat LaVarre
2004-05-14 19:50 ` Jeff Garzik
2004-05-14 20:12 ` Pat LaVarre
2004-05-14 23:47 ` SATA ATAPI work in progress Pat LaVarre
2004-05-15 0:02 ` Pat LaVarre [this message]
2004-05-15 0:38 ` Jeff Garzik
2004-05-15 13:06 ` Pat LaVarre
2004-05-15 13:49 ` Pat LaVarre
2004-05-15 15:27 ` Jeff Garzik
2004-05-15 15:49 ` Pat LaVarre
2004-05-15 15:56 ` Pat LaVarre
2004-05-15 16:04 ` Pat LaVarre
2004-05-15 16:32 ` Jeff Garzik
2004-05-15 16:43 ` Pat LaVarre
2004-05-15 16:50 ` Pat LaVarre
2004-05-15 16:30 ` Jeff Garzik
2004-05-15 0:46 ` [PATCH] " Jeff Garzik
2004-05-15 13:08 ` Pat LaVarre
2004-05-15 13:10 ` Pat LaVarre
2004-05-15 14:13 ` Pat LaVarre
2004-05-14 18:28 ` Pat LaVarre
2004-05-14 18:38 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1084579362.3271.5.camel@patibmrh9 \
--to=p.lavarre@ieee.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox