Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>, Tommy Kelly <linux@tkel.ly>,
	Damien Le Moal <dlemoal@kernel.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	John Garry <john.g.garry@oracle.com>,
	linux-ide@vger.kernel.org,
	David Dreschner <kernel-2026@dreschner.net>
Subject: Re: [PATCH v5 0/4] ata: fix deferred QC handling for port multipliers
Date: Wed, 27 May 2026 10:32:18 +0200	[thread overview]
Message-ID: <2026052710-vivacious-strep-d3e5@gregkh> (raw)
In-Reply-To: <ahaqmgFGMwO0hPNo@ryzen>

On Wed, May 27, 2026 at 10:26:02AM +0200, Niklas Cassel wrote:
> On Tue, May 26, 2026 at 08:47:53PM +0200, David Dreschner wrote:
> > Hello Niklas,
> > 
> > thank you very much for fixing the issue!
> > 
> > I tested the first three patches manually on my Debian 13 machine with
> > kernel 6.12.90 and can indeed confirm that your patches fixes the issue. The
> > fourth patch had some merge-conflicts and were therefore skipped - I'm
> > unable to test the changes anyway (my HBA only supports CBS).
> > 
> > Machine: HP MicroServer Gen8
> > HBA: HP Dynamic Smart Array B120i
> > Port multiplier: StarTech S322M225R (SATA to 2x M.2 SATA using ASM1092R
> > chipset in JBOD mode)
> > 
> > Could you please make sure that the fixes are being backported to all
> > versions that contain the faulty commit 0ea84089dbf6? Looks like that is
> > necessary for v7.0, v6.18, v6.12 and v6.6.
> > 
> > If not, it would be great to get the fixes at least merged into v6.12, as
> > I'm otherwise forced to manually build any new stable kernel that's being
> > pushed by the Debian team.
> > 
> > Thanks again and greetings from Germany!
> > David
> 
> Dear stable maintainers,
> 
> Sorry for the extra work put on you.
> 
> Could your please help us backport:
> 
> $ git log --reverse --oneline v7.1-rc4..v7.1-rc5 drivers/ata/
> 360190bd965f ata: libata-scsi: improve readability of ata_scsi_qc_issue()
> ce4548807d2e ata: libata-scsi: do not use the deferred QC feature for ATA_DEFER_PORT
> f233124fb36c ata: libata-scsi: do not use the deferred QC feature on PMPs with CBS
> 759e8756da00 ata: libata-scsi: do not needlessly defer commands when using PMP with FBS
> 
> 
> The first three patches apply cleanly to at least v6.12.
> 
> The final commit does not apply cleanly, attaching a backported version.
> 
> Again, sorry for the trouble.
> Hopefully our AI overlords / Sashiko will manage to find some of these
> problems that was missed during the review of the faulty commit.

Now queued up, thanks.

greg k-h

      reply	other threads:[~2026-05-27  8:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14  7:38 [PATCH v5 0/4] ata: fix deferred QC handling for port multipliers Niklas Cassel
2026-05-14  7:38 ` [PATCH v5 1/4] ata: libata-scsi: improve readability of ata_scsi_qc_issue() Niklas Cassel
2026-05-18  9:19   ` Damien Le Moal
2026-05-14  7:39 ` [PATCH v5 2/4] ata: libata-scsi: do not use the deferred QC feature for ATA_DEFER_PORT Niklas Cassel
2026-05-18  9:20   ` Damien Le Moal
2026-05-14  7:39 ` [PATCH v5 3/4] ata: libata-scsi: do not use the deferred QC feature on PMPs with CBS Niklas Cassel
2026-05-18  9:23   ` Damien Le Moal
2026-05-14  7:39 ` [PATCH v5 4/4] ata: libata-scsi: do not needlessly defer commands when using PMP with FBS Niklas Cassel
2026-05-18  9:24   ` Damien Le Moal
2026-05-14 10:43 ` [PATCH v5 0/4] ata: fix deferred QC handling for port multipliers Tommy Kelly
2026-05-14 11:17   ` Niklas Cassel
2026-05-18 10:33   ` Niklas Cassel
2026-05-18 10:37 ` Niklas Cassel
2026-05-26 18:47 ` David Dreschner
2026-05-27  8:26   ` Niklas Cassel
2026-05-27  8:32     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026052710-vivacious-strep-d3e5@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=john.g.garry@oracle.com \
    --cc=kernel-2026@dreschner.net \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux@tkel.ly \
    --cc=martin.petersen@oracle.com \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox