From: Niklas Cassel <cassel@kernel.org>
To: Tommy Kelly <linux@tkel.ly>
Cc: linux-ide@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
John Garry <john.g.garry@oracle.com>
Subject: Re: [PATCH v5 0/4] ata: fix deferred QC handling for port multipliers
Date: Thu, 14 May 2026 13:17:21 +0200 [thread overview]
Message-ID: <agWvQd0I-Sr1ZKfA@fedora> (raw)
In-Reply-To: <87402a36-57ef-40a5-8668-988f58e31ca9@tkel.ly>
Hello Tommy,
On Thu, May 14, 2026 at 03:43:30AM -0700, Tommy Kelly wrote:
> On 5/14/26 00:38, Niklas Cassel wrote:
> > Changes since v4:
> > -Fix ATA_DEFER_LINK_EXCL to use the correct goto label. While refactoring,
> > I accidentally used the wrong label goto defer_qc instead of goto free_qc,
> > which of course broke PMP CBS in v4.
> >
>
> Good news!
>
> Tested with Linux v7.1-rc3 + v5 patch series.
>
> Both FBS + CBS worked fine, no errors/warnings or visible issues.
Thank you very much for all your help with reporting the issue and also
helping out with testing. Much appreciated!
If there are no new review comments on V5, this will most likely be queued
up in a few days.
Considering how broken the PMP CBS support is in Linus's tree right now,
this series should probably go into 7.1, even though it is quite big,
but I don't see any other option.
Kind regards,
Niklas
prev parent reply other threads:[~2026-05-14 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 7:38 [PATCH v5 0/4] ata: fix deferred QC handling for port multipliers Niklas Cassel
2026-05-14 7:38 ` [PATCH v5 1/4] ata: libata-scsi: improve readability of ata_scsi_qc_issue() Niklas Cassel
2026-05-14 7:39 ` [PATCH v5 2/4] ata: libata-scsi: do not use the deferred QC feature for ATA_DEFER_PORT Niklas Cassel
2026-05-14 7:39 ` [PATCH v5 3/4] ata: libata-scsi: do not use the deferred QC feature on PMPs with CBS Niklas Cassel
2026-05-14 7:39 ` [PATCH v5 4/4] ata: libata-scsi: do not needlessly defer commands when using PMP with FBS Niklas Cassel
2026-05-14 10:43 ` [PATCH v5 0/4] ata: fix deferred QC handling for port multipliers Tommy Kelly
2026-05-14 11:17 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agWvQd0I-Sr1ZKfA@fedora \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux@tkel.ly \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox