[PATCH] Staging: iio: adc: align multi-line function argument with open parenthesis

[PATCH] Staging: iio: adc: align multi-line function argument with open parenthesis

[Enrique Vargas]

Eliminate WARNING found with checkpatch.pl for argument split in two
lines not matching coding conventions identation.

Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
---
 drivers/staging/iio/adc/ad7192.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index 51b1cd3ad1de..5f65d084e320 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -477,7 +477,7 @@ static ssize_t ad7192_set(struct device *dev,
 }
 
 static void ad7192_get_available_filter_freq(struct ad7192_state *st,
-						    int *freq)
+					     int *freq)
 {
 	unsigned int fadc;
 
-- 
2.17.1

Re: [Outreachy kernel] [PATCH] Staging: iio: adc: align multi-line function argument with open parenthesis

[Julia Lawall]

On Thu, 12 Mar 2020, Enrique Vargas wrote:

> Eliminate WARNING found with checkpatch.pl for argument split in two
> lines not matching coding conventions identation.

The message seems a bit obscure.  There is no argument that is split in
two lines, although it is the case that the argument list is split in two
lines.

For the subject line, maybe "reduce parameter indentation"

And then for the log message:

"Align function parameter with the right side of the open parenthesis
starting the parameter list, to follow kernel coding style.  Problem found
using checkpatch."

julia


>
> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> ---
>  drivers/staging/iio/adc/ad7192.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 51b1cd3ad1de..5f65d084e320 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -477,7 +477,7 @@ static ssize_t ad7192_set(struct device *dev,
>  }
>
>  static void ad7192_get_available_filter_freq(struct ad7192_state *st,
> -						    int *freq)
> +					     int *freq)
>  {
>  	unsigned int fadc;
>
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200312142721.GA2748%40evX1.
>