* [PATCH v2] iio: accel: fxls8962af: fix potential use of uninitialized symbol
@ 2021-07-09 7:17 Sean Nyekjaer
2021-07-13 17:47 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Sean Nyekjaer @ 2021-07-09 7:17 UTC (permalink / raw)
To: Jonathan Cameron, Lars-Peter Clausen, Sean Nyekjaer
Cc: andy.shevchenko, kernel test robot, Dan Carpenter,
Jonathan Cameron, linux-iio, linux-kernel
Fix this warning from kernel test robot:
smatch warnings:
drivers/iio/accel/fxls8962af-core.c:640
fxls8962af_i2c_raw_read_errata3() error: uninitialized symbol 'ret'.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sean Nyekjaer <sean@geanix.com>
Fixes: af959b7b96b8 ("iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads")
---
Changes since v2:
- add commit msg
drivers/iio/accel/fxls8962af-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
index 078d87865fde..0019f1ea7df2 100644
--- a/drivers/iio/accel/fxls8962af-core.c
+++ b/drivers/iio/accel/fxls8962af-core.c
@@ -637,7 +637,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct fxls8962af_data *data,
return ret;
}
- return ret;
+ return 0;
}
static int fxls8962af_fifo_transfer(struct fxls8962af_data *data,
--
2.31.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] iio: accel: fxls8962af: fix potential use of uninitialized symbol
2021-07-09 7:17 [PATCH v2] iio: accel: fxls8962af: fix potential use of uninitialized symbol Sean Nyekjaer
@ 2021-07-13 17:47 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2021-07-13 17:47 UTC (permalink / raw)
To: Sean Nyekjaer
Cc: Lars-Peter Clausen, andy.shevchenko, kernel test robot,
Dan Carpenter, Jonathan Cameron, linux-iio, linux-kernel
On Fri, 9 Jul 2021 09:17:27 +0200
Sean Nyekjaer <sean@geanix.com> wrote:
> Fix this warning from kernel test robot:
> smatch warnings:
> drivers/iio/accel/fxls8962af-core.c:640
> fxls8962af_i2c_raw_read_errata3() error: uninitialized symbol 'ret'.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> Fixes: af959b7b96b8 ("iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads")
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
> ---
> Changes since v2:
> - add commit msg
>
> drivers/iio/accel/fxls8962af-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
> index 078d87865fde..0019f1ea7df2 100644
> --- a/drivers/iio/accel/fxls8962af-core.c
> +++ b/drivers/iio/accel/fxls8962af-core.c
> @@ -637,7 +637,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct fxls8962af_data *data,
> return ret;
> }
>
> - return ret;
> + return 0;
> }
>
> static int fxls8962af_fifo_transfer(struct fxls8962af_data *data,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-13 17:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-09 7:17 [PATCH v2] iio: accel: fxls8962af: fix potential use of uninitialized symbol Sean Nyekjaer
2021-07-13 17:47 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox