Re: [PATCH v2 2/2] iio: light: stk3310: Update includes to match IWYU

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 28 Apr 2026 18:49:36 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:

> On Tue, 28 Apr 2026 at 18:14, Rafael G. Dias
> <rafael.guimaraes.dias@usp.br> wrote:
> >
> > Clean up the included headers in stk3310.c according to the
> > Include-What-You-Use (IWYU) tool. Remove the generic <linux/kernel.h>
> > header and add explicit dependencies to improve compilation accuracy.
> >
> > Co-developed-by: Felipe Khoury Dayoub <felipedayoub@usp.br>
> > Signed-off-by: Felipe Khoury Dayoub <felipedayoub@usp.br>
> > Signed-off-by: Rafael G. Dias <rafael.guimaraes.dias@usp.br>
https://sashiko.dev/#/patchset/20260428161339.1187956-1-rafael.guimaraes.dias%40usp.br
Had a few comments.  I added asm/byteorder.h and linux/sysfs.h.

Maybe we could argue the sysfs.h one will always be included by
iio/sysfs.h but I think it's better to explicitly include it
for struct attribute_group and similar.

The asm/byteorder.h is simpler one as that should definitely be here.

Anyhow, tweaked whilst applying and applied to the testing branch of
iio.git.

However, do slow down a bit as Joshua suggested - I'd generally
suggest a week between first version and second, but I am a bit
more relaxed on this for students and new submitters doing fairly
simple patches.

Thanks,

Jonathan

> > ---
> >  drivers/iio/light/stk3310.c | 13 ++++++++++++-
> >  1 file changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c
> > index 1fad9367c2d4..37b7b9367269 100644
> > --- a/drivers/iio/light/stk3310.c
> > +++ b/drivers/iio/light/stk3310.c
> > @@ -7,16 +7,27 @@
> >   * IIO driver for STK3310/STK3311. 7-bit I2C address: 0x48.
> >   */
> >
> > +#include <linux/array_size.h>
> > +#include <linux/bits.h>
> > +#include <linux/dev_printk.h>
> > +#include <linux/err.h>
> > +#include <linux/errno.h>
> >  #include <linux/i2c.h>
> >  #include <linux/interrupt.h>
> > -#include <linux/kernel.h>
> > +#include <linux/irqreturn.h>
> >  #include <linux/mod_devicetable.h>
> >  #include <linux/module.h>
> > +#include <linux/mutex.h>
> > +#include <linux/pm.h>
> > +#include <linux/property.h>
> >  #include <linux/regmap.h>
> > +#include <linux/sprintf.h>
> > +#include <linux/types.h>
> >
> >  #include <linux/iio/events.h>
> >  #include <linux/iio/iio.h>
> >  #include <linux/iio/sysfs.h>
> > +#include <linux/iio/types.h>
> >
> >  #define STK3310_REG_STATE                      0x00
> >  #define STK3310_REG_PSCTRL                     0x01
> > --
> > 2.43.0
> >  
> 
> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
>