public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Rafael G. Dias" <rafael.guimaraes.dias@usp.br>,
	dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	linux-iio@vger.kernel.org, joshua.crofts1@gmail.com,
	Felipe Khoury Dayoub <felipedayoub@usp.br>
Subject: Re: [PATCH v2 2/2] iio: light: stk3310: Update includes to match IWYU
Date: Mon, 4 May 2026 16:28:03 +0100	[thread overview]
Message-ID: <20260504162803.7d12c156@jic23-huawei> (raw)
In-Reply-To: <afJg4G3oyfCZ-UiS@ashevche-desk.local>

On Wed, 29 Apr 2026 22:49:52 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Tue, Apr 28, 2026 at 01:13:39PM -0300, Rafael G. Dias wrote:
> > Clean up the included headers in stk3310.c according to the
> > Include-What-You-Use (IWYU) tool. Remove the generic <linux/kernel.h>
> > header and add explicit dependencies to improve compilation accuracy.  
> 
> ...
> 
> > +#include <linux/dev_printk.h>
> > +#include <linux/err.h>
> > +#include <linux/errno.h>  
> 
> In most cases we assume errno (but strictly speaking it's asm/errno) is
> included by err.h. Double check if there are no codes >= 512 are in use in the
> driver. If no, drop errno.h.
> 
I dropped that as well as it's all simple -EINVAL/ -ENOMEM
> >  #include <linux/i2c.h>
> >  #include <linux/interrupt.h>
> > -#include <linux/kernel.h>  
> 
> > +#include <linux/irqreturn.h>  
> 
> Implied by interrupt.h.
> 
> >  #include <linux/mod_devicetable.h>
> >  #include <linux/module.h>
> > +#include <linux/mutex.h>
> > +#include <linux/pm.h>
> > +#include <linux/property.h>
> >  #include <linux/regmap.h>
> > +#include <linux/sprintf.h>
> > +#include <linux/types.h>  
> 


  reply	other threads:[~2026-05-04 15:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28 16:13 [PATCH v2 1/2] iio: light: stk3310: Sort headers alphabetically Rafael G. Dias
2026-04-28 16:13 ` [PATCH v2 2/2] iio: light: stk3310: Update includes to match IWYU Rafael G. Dias
2026-04-28 16:49   ` Joshua Crofts
2026-04-29 10:23     ` Jonathan Cameron
     [not found]       ` <CAPBn40g+PPyxnVfLn8q2bGgtQ=Zy1VBQW3qQeje=v9sTSx0N5Q@mail.gmail.com>
2026-04-29 19:18         ` Rafael Guimaraes Dias
2026-04-29 19:51       ` Andy Shevchenko
2026-05-04 15:26         ` Jonathan Cameron
2026-04-29 19:49   ` Andy Shevchenko
2026-05-04 15:28     ` Jonathan Cameron [this message]
2026-04-28 16:37 ` [PATCH v2 1/2] iio: light: stk3310: Sort headers alphabetically Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260504162803.7d12c156@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=felipedayoub@usp.br \
    --cc=joshua.crofts1@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=rafael.guimaraes.dias@usp.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox