Re: [PATCH v2 2/2] iio: light: stk3310: Update includes to match IWYU

[Jonathan Cameron <jic23@kernel.org>]

On Wed, 29 Apr 2026 22:51:43 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Wed, Apr 29, 2026 at 11:23:00AM +0100, Jonathan Cameron wrote:
> > On Tue, 28 Apr 2026 18:49:36 +0200
> > Joshua Crofts <joshua.crofts1@gmail.com> wrote:  
> > > On Tue, 28 Apr 2026 at 18:14, Rafael G. Dias
> > > <rafael.guimaraes.dias@usp.br> wrote:  
> > > >
> > > > Clean up the included headers in stk3310.c according to the
> > > > Include-What-You-Use (IWYU) tool. Remove the generic <linux/kernel.h>
> > > > header and add explicit dependencies to improve compilation accuracy.
> > > >
> > > > Co-developed-by: Felipe Khoury Dayoub <felipedayoub@usp.br>
> > > > Signed-off-by: Felipe Khoury Dayoub <felipedayoub@usp.br>
> > > > Signed-off-by: Rafael G. Dias <rafael.guimaraes.dias@usp.br>  
> > https://sashiko.dev/#/patchset/20260428161339.1187956-1-rafael.guimaraes.dias%40usp.br
> > Had a few comments.  I added asm/byteorder.h and linux/sysfs.h.
> > 
> > Maybe we could argue the sysfs.h one will always be included by
> > iio/sysfs.h but I think it's better to explicitly include it
> > for struct attribute_group and similar.
> > 
> > The asm/byteorder.h is simpler one as that should definitely be here.
> > 
> > Anyhow, tweaked whilst applying and applied to the testing branch of
> > iio.git.  
> 
> Please, also drop irqreturn.h as implied by interrupt.h.
> 
Done.