From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Joshua Crofts <joshua.crofts1@gmail.com>,
"Rafael G. Dias" <rafael.guimaraes.dias@usp.br>,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org,
Felipe Khoury Dayoub <felipedayoub@usp.br>
Subject: Re: [PATCH v2 2/2] iio: light: stk3310: Update includes to match IWYU
Date: Wed, 29 Apr 2026 22:51:43 +0300 [thread overview]
Message-ID: <afJhT6z0qwQL-tuQ@ashevche-desk.local> (raw)
In-Reply-To: <20260429112300.696e2722@jic23-huawei>
On Wed, Apr 29, 2026 at 11:23:00AM +0100, Jonathan Cameron wrote:
> On Tue, 28 Apr 2026 18:49:36 +0200
> Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> > On Tue, 28 Apr 2026 at 18:14, Rafael G. Dias
> > <rafael.guimaraes.dias@usp.br> wrote:
> > >
> > > Clean up the included headers in stk3310.c according to the
> > > Include-What-You-Use (IWYU) tool. Remove the generic <linux/kernel.h>
> > > header and add explicit dependencies to improve compilation accuracy.
> > >
> > > Co-developed-by: Felipe Khoury Dayoub <felipedayoub@usp.br>
> > > Signed-off-by: Felipe Khoury Dayoub <felipedayoub@usp.br>
> > > Signed-off-by: Rafael G. Dias <rafael.guimaraes.dias@usp.br>
> https://sashiko.dev/#/patchset/20260428161339.1187956-1-rafael.guimaraes.dias%40usp.br
> Had a few comments. I added asm/byteorder.h and linux/sysfs.h.
>
> Maybe we could argue the sysfs.h one will always be included by
> iio/sysfs.h but I think it's better to explicitly include it
> for struct attribute_group and similar.
>
> The asm/byteorder.h is simpler one as that should definitely be here.
>
> Anyhow, tweaked whilst applying and applied to the testing branch of
> iio.git.
Please, also drop irqreturn.h as implied by interrupt.h.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-29 19:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 16:13 [PATCH v2 1/2] iio: light: stk3310: Sort headers alphabetically Rafael G. Dias
2026-04-28 16:13 ` [PATCH v2 2/2] iio: light: stk3310: Update includes to match IWYU Rafael G. Dias
2026-04-28 16:49 ` Joshua Crofts
2026-04-29 10:23 ` Jonathan Cameron
[not found] ` <CAPBn40g+PPyxnVfLn8q2bGgtQ=Zy1VBQW3qQeje=v9sTSx0N5Q@mail.gmail.com>
2026-04-29 19:18 ` Rafael Guimaraes Dias
2026-04-29 19:51 ` Andy Shevchenko [this message]
2026-05-04 15:26 ` Jonathan Cameron
2026-04-29 19:49 ` Andy Shevchenko
2026-05-04 15:28 ` Jonathan Cameron
2026-04-28 16:37 ` [PATCH v2 1/2] iio: light: stk3310: Sort headers alphabetically Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afJhT6z0qwQL-tuQ@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=felipedayoub@usp.br \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rafael.guimaraes.dias@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox