From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Gabriel Braga Lagrotaria <gabrielblo@ime.usp.br>,
andy@kernel.org, dlechner@baylibre.com,
javier.carrasco.cruz@gmail.com, nuno.sa@analog.com,
ricardo.kojo@ime.usp.br, elliancarlos@gmail.com,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: light: veml6030: Generalize hw_init for veml6030 and veml6035
Date: Mon, 4 May 2026 17:28:28 +0100 [thread overview]
Message-ID: <20260504172828.0939ce30@jic23-huawei> (raw)
In-Reply-To: <afip4G46Bkj4iEka@ashevche-desk.local>
On Mon, 4 May 2026 17:14:56 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Sat, May 02, 2026 at 08:41:04PM -0300, Gabriel Braga Lagrotaria wrote:
> > Modify veml6030_hw_init() function to deduplicate the setup logic
> > for veml6030_hw_init() and veml6035_hw_init(), and remove
> > veml6035_hw_init().
> >
> > Additionally, introduce struct veml6030_hw_init_config_desc to store and
> > pass the custom configuration values specific to each device variation.
>
> ...
>
> > @@ -963,61 +972,21 @@ static int veml6030_regfield_init(struct iio_dev *indio_dev)
> > return 0;
> > }
> >
> > +
>
> I can argue that this is a stray change, but I'm not objecting to having it.
I am. Don't see a reason for two blank lines here.
There are subsystems where that is standard formatting, but it's not in IIO
and this driver doesn't do double blank lines anywhere else.
I guess Garbriel has been looking at other drivers where that style may
be in use.
next prev parent reply other threads:[~2026-05-04 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-02 23:41 [PATCH v2 0/2] iio: light: veml6030: Generalize hw_init and cleanup naming Gabriel Braga Lagrotaria
2026-05-02 23:41 ` [PATCH v2 1/2] iio: light: veml6030: Remove 'x' wildcard usages in file Gabriel Braga Lagrotaria
2026-05-03 9:23 ` Joshua Crofts
2026-05-02 23:41 ` [PATCH v2 2/2] iio: light: veml6030: Generalize hw_init for veml6030 and veml6035 Gabriel Braga Lagrotaria
2026-05-03 0:02 ` Maxwell Doose
2026-05-04 14:14 ` Andy Shevchenko
2026-05-04 16:28 ` Jonathan Cameron [this message]
2026-05-04 16:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504172828.0939ce30@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=elliancarlos@gmail.com \
--cc=gabrielblo@ime.usp.br \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=ricardo.kojo@ime.usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox