Re: [PATCH v2 2/2] iio: light: veml6030: Generalize hw_init for veml6030 and veml6035

["Maxwell Doose" <m32285159@gmail.com>]

Hi there,

On Sat May 2, 2026 at 6:41 PM CDT, Gabriel Braga Lagrotaria <gabrielblo@ime.usp.br> wrote:
> Modify veml6030_hw_init() function to deduplicate the setup logic
> for veml6030_hw_init() and veml6035_hw_init(), and remove
> veml6035_hw_init().
>
> Additionally, introduce struct veml6030_hw_init_config_desc to store and
> pass the custom configuration values specific to each device variation.
>
> Signed-off-by: Gabriel Braga Lagrotaria <gabrielblo@ime.usp.br>
> Co-developed-by: Ricardo H H Kojo <ricardo.kojo@ime.usp.br>
> Signed-off-by: Ricardo H H Kojo <ricardo.kojo@ime.usp.br>
> Co-developed-by: Ellian Carlos <elliancarlos@gmail.com>
> Signed-off-by: Ellian Carlos <elliancarlos@gmail.com>
> ---
>  drivers/iio/light/veml6030.c | 92 +++++++++++++++---------------------
>  1 file changed, 37 insertions(+), 55 deletions(-)
>
[snip]

Just curious, how was this tested? It seems like you're modifying the
writing logic as well, and ordinarily patches like these don't get
merged unless properly tested. I haven't fully looked over it yet but I
just wanted some background before I start.

best regards,
maxwell