Re: [PATCH v2 2/2] iio: light: veml6030: Generalize hw_init for veml6030 and veml6035

[Jonathan Cameron <jic23@kernel.org>]

On Sat,  2 May 2026 20:41:04 -0300
Gabriel Braga Lagrotaria <gabrielblo@ime.usp.br> wrote:

> Modify veml6030_hw_init() function to deduplicate the setup logic
> for veml6030_hw_init() and veml6035_hw_init(), and remove
> veml6035_hw_init().
> 
> Additionally, introduce struct veml6030_hw_init_config_desc to store and
> pass the custom configuration values specific to each device variation.
> 
> Signed-off-by: Gabriel Braga Lagrotaria <gabrielblo@ime.usp.br>
> Co-developed-by: Ricardo H H Kojo <ricardo.kojo@ime.usp.br>
> Signed-off-by: Ricardo H H Kojo <ricardo.kojo@ime.usp.br>
> Co-developed-by: Ellian Carlos <elliancarlos@gmail.com>
> Signed-off-by: Ellian Carlos <elliancarlos@gmail.com>
Hi All,

A few additional comments from me.

> @@ -1074,9 +1051,11 @@ static int veml6035_hw_init(struct iio_dev *indio_dev, struct device *dev)
>  		return dev_err_probe(dev, ret,
>  				     "can't clear als interrupt status\n");
>  
> -	return 0;
> +	return ret;

Why?  If we can get here with anything that isn't 0 then fair enough, but I can't
see any change to make that now the case.  If we know it is zero then explicitly
returning that is good for readability.

>  }
>  
> +
> +
Please proofread your own patches for stuff like this.  It's very
easy to introduce stray changes as you develop your code so only
way to catch them is too look at the end result before sending it out.

Jonathan