Re: [PATCH v2 2/2] iio: light: veml6030: Generalize hw_init for veml6030 and veml6035

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Sat, May 02, 2026 at 08:41:04PM -0300, Gabriel Braga Lagrotaria wrote:
> Modify veml6030_hw_init() function to deduplicate the setup logic
> for veml6030_hw_init() and veml6035_hw_init(), and remove
> veml6035_hw_init().
> 
> Additionally, introduce struct veml6030_hw_init_config_desc to store and
> pass the custom configuration values specific to each device variation.

...

> @@ -963,61 +972,21 @@ static int veml6030_regfield_init(struct iio_dev *indio_dev)
>  	return 0;
>  }
>  
> +

I can argue that this is a stray change, but I'm not objecting to having it.

>  /*
>   * Set ALS gain to 1/8, integration time to 100 ms, PSM to mode 2,
>   * persistence to 1 x integration time and the threshold
>   * interrupt disabled by default. First shutdown the sensor,
>   * update registers and then power on the sensor.
>   */

...

> +static const struct veml6030_hw_init_config_desc veml6030_hw_init_config = {
> +	.gain_sel = veml6030_gain_sel,
> +	.gain_sel_size = ARRAY_SIZE(veml6030_gain_sel),
> +	.gain_max_scale_int = 2,
> +	.gain_max_scale_nano = 150400000,
> +	.reg_als_conf_value = 0x1001,
> +};
>  
> -	return ret;
> -}
>  

Now here are two blank lines? One is enough.

...

> @@ -1074,9 +1051,11 @@ static int veml6035_hw_init(struct iio_dev *indio_dev, struct device *dev)
>  		return dev_err_probe(dev, ret,
>  				     "can't clear als interrupt status\n");
>  
> -	return 0;
> +	return ret;
>  }
>  
> +
> +

Ditto.

>  static int veml6030_probe(struct i2c_client *client)
>  {
>  	int ret;
> @@ -1167,6 +1146,7 @@ static int veml6030_runtime_resume(struct device *dev)
>  static DEFINE_RUNTIME_DEV_PM_OPS(veml6030_pm_ops, veml6030_runtime_suspend,
>  				 veml6030_runtime_resume, NULL);
>  
> +

Stray change.

>  static const struct veml6030_chip_desc veml6030_chip = {
>  	.name = "veml6030",
>  	.channels = veml6030_channels,

-- 
With Best Regards,
Andy Shevchenko