* [PATCH] dt-bindings: iio: dac: mcp47feb02: Fix I2C address in example
@ 2026-04-20 10:36 Ariana Lazar
2026-04-20 12:22 ` Jonathan Cameron
2026-04-20 12:29 ` Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Ariana Lazar @ 2026-04-20 10:36 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Conor Dooley, Jonathan Cameron, linux-iio, devicetree,
linux-kernel, Ariana Lazar
Change example reg value from 0 to 0x60 in order to use a valid I2C address
Fixes: 4ba12d304175 ("dt-bindings: iio: dac: adding support for Microchip MCP47FEB02")
Link: https://lore.kernel.org/all/dd0dbadb-604b-4f12-8674-268b7db096fd@baylibre.com/
Signed-off-by: Ariana Lazar <ariana.lazar@microchip.com>
---
.../bindings/iio/dac/microchip,mcp47feb02.yaml | 32 +++++++++++-----------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
index d2466aa6bda2106a8b695347a0edf38462294d03..95ddc8321eff34ed27dab8ce712210d2cb9ae785 100644
--- a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
@@ -280,23 +280,23 @@ examples:
#address-cells = <1>;
#size-cells = <0>;
- dac@0 {
- compatible = "microchip,mcp47feb02";
- reg = <0>;
- vdd-supply = <&vdac_vdd>;
- vref-supply = <&vref_reg>;
+ dac@60 {
+ compatible = "microchip,mcp47feb02";
+ reg = <0x60>;
+ vdd-supply = <&vdac_vdd>;
+ vref-supply = <&vref_reg>;
- #address-cells = <1>;
- #size-cells = <0>;
- channel@0 {
- reg = <0>;
- label = "Adjustable_voltage_ch0";
- };
+ #address-cells = <1>;
+ #size-cells = <0>;
+ channel@0 {
+ reg = <0>;
+ label = "Adjustable_voltage_ch0";
+ };
- channel@1 {
- reg = <0x1>;
- label = "Adjustable_voltage_ch1";
- };
- };
+ channel@1 {
+ reg = <0x1>;
+ label = "Adjustable_voltage_ch1";
+ };
+ };
};
...
---
base-commit: d2a4ec19d2a2e54c23b5180e939994d3da4a6b91
change-id: 20260417-mcp47feb02-fix6-bd6694d84750
Best regards,
--
Ariana Lazar <ariana.lazar@microchip.com>
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: iio: dac: mcp47feb02: Fix I2C address in example
2026-04-20 10:36 [PATCH] dt-bindings: iio: dac: mcp47feb02: Fix I2C address in example Ariana Lazar
@ 2026-04-20 12:22 ` Jonathan Cameron
2026-04-21 14:09 ` Ariana.Lazar
2026-04-20 12:29 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Jonathan Cameron @ 2026-04-20 12:22 UTC (permalink / raw)
To: Ariana Lazar
Cc: David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Conor Dooley, Jonathan Cameron,
linux-iio, devicetree, linux-kernel
On Mon, 20 Apr 2026 13:36:02 +0300
Ariana Lazar <ariana.lazar@microchip.com> wrote:
> Change example reg value from 0 to 0x60 in order to use a valid I2C address
>
> Fixes: 4ba12d304175 ("dt-bindings: iio: dac: adding support for Microchip MCP47FEB02")
> Link: https://lore.kernel.org/all/dd0dbadb-604b-4f12-8674-268b7db096fd@baylibre.com/
> Signed-off-by: Ariana Lazar <ariana.lazar@microchip.com>
> ---
> .../bindings/iio/dac/microchip,mcp47feb02.yaml | 32 +++++++++++-----------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> index d2466aa6bda2106a8b695347a0edf38462294d03..95ddc8321eff34ed27dab8ce712210d2cb9ae785 100644
> --- a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> @@ -280,23 +280,23 @@ examples:
>
> #address-cells = <1>;
> #size-cells = <0>;
> - dac@0 {
> - compatible = "microchip,mcp47feb02";
> - reg = <0>;
> - vdd-supply = <&vdac_vdd>;
> - vref-supply = <&vref_reg>;
> + dac@60 {
> + compatible = "microchip,mcp47feb02";
Why is this indent changing?
> + reg = <0x60>;
> + vdd-supply = <&vdac_vdd>;
> + vref-supply = <&vref_reg>;
>
> - #address-cells = <1>;
> - #size-cells = <0>;
> - channel@0 {
> - reg = <0>;
> - label = "Adjustable_voltage_ch0";
> - };
> + #address-cells = <1>;
> + #size-cells = <0>;
> + channel@0 {
> + reg = <0>;
> + label = "Adjustable_voltage_ch0";
> + };
>
> - channel@1 {
> - reg = <0x1>;
> - label = "Adjustable_voltage_ch1";
> - };
> - };
> + channel@1 {
> + reg = <0x1>;
> + label = "Adjustable_voltage_ch1";
> + };
> + };
> };
> ...
>
> ---
> base-commit: d2a4ec19d2a2e54c23b5180e939994d3da4a6b91
> change-id: 20260417-mcp47feb02-fix6-bd6694d84750
>
> Best regards,
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: iio: dac: mcp47feb02: Fix I2C address in example
2026-04-20 12:22 ` Jonathan Cameron
@ 2026-04-21 14:09 ` Ariana.Lazar
2026-04-21 15:01 ` Jonathan Cameron
0 siblings, 1 reply; 5+ messages in thread
From: Ariana.Lazar @ 2026-04-21 14:09 UTC (permalink / raw)
To: jic23
Cc: dlechner, nuno.sa, Conor.Dooley, Jonathan.Cameron, robh,
linux-iio, andy, krzk+dt, linux-kernel, conor+dt, devicetree
Hello Jonathan,
> > @@ -280,23 +280,23 @@ examples:
> >
> > #address-cells = <1>;
> > #size-cells = <0>;
> > - dac@0 {
> > - compatible = "microchip,mcp47feb02";
> > - reg = <0>;
> > - vdd-supply = <&vdac_vdd>;
> > - vref-supply = <&vref_reg>;
> > + dac@60 {
> > + compatible = "microchip,mcp47feb02";
> Why is this indent changing?
>
> > + reg = <0x60>;
> > + vdd-supply = <&vdac_vdd>;
> > + vref-supply = <&vref_reg>;
> >
> > - #address-cells = <1>;
> > - #size-cells = <0>;
> > - channel@0 {
> > - reg = <0>;
> > - label = "Adjustable_voltage_ch0";
> > - };
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + channel@0 {
> > + reg = <0>;
> > + label = "Adjustable_voltage_ch0";
> > + };
> >
> > - channel@1 {
> > - reg = <0x1>;
> > - label = "Adjustable_voltage_ch1";
> > - };
> > - };
> > + channel@1 {
> > + reg = <0x1>;
> > + label = "Adjustable_voltage_ch1";
> > + };
> > + };
> > };
> > ...
>
Thank you for the review.
1. I updated the example indentation in order to use consistent 4-
space indentation, instead of mixing with 2-space as in the
previous version.
Best regards,
Ariana
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: iio: dac: mcp47feb02: Fix I2C address in example
2026-04-21 14:09 ` Ariana.Lazar
@ 2026-04-21 15:01 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2026-04-21 15:01 UTC (permalink / raw)
To: Ariana.Lazar
Cc: dlechner, nuno.sa, Conor.Dooley, Jonathan.Cameron, robh,
linux-iio, andy, krzk+dt, linux-kernel, conor+dt, devicetree
On Tue, 21 Apr 2026 14:09:48 +0000
<Ariana.Lazar@microchip.com> wrote:
> Hello Jonathan,
>
> > > @@ -280,23 +280,23 @@ examples:
> > >
> > > #address-cells = <1>;
> > > #size-cells = <0>;
> > > - dac@0 {
> > > - compatible = "microchip,mcp47feb02";
> > > - reg = <0>;
> > > - vdd-supply = <&vdac_vdd>;
> > > - vref-supply = <&vref_reg>;
> > > + dac@60 {
> > > + compatible = "microchip,mcp47feb02";
> > Why is this indent changing?
> >
> > > + reg = <0x60>;
> > > + vdd-supply = <&vdac_vdd>;
> > > + vref-supply = <&vref_reg>;
> > >
> > > - #address-cells = <1>;
> > > - #size-cells = <0>;
> > > - channel@0 {
> > > - reg = <0>;
> > > - label = "Adjustable_voltage_ch0";
> > > - };
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > + channel@0 {
> > > + reg = <0>;
> > > + label = "Adjustable_voltage_ch0";
> > > + };
> > >
> > > - channel@1 {
> > > - reg = <0x1>;
> > > - label = "Adjustable_voltage_ch1";
> > > - };
> > > - };
> > > + channel@1 {
> > > + reg = <0x1>;
> > > + label = "Adjustable_voltage_ch1";
> > > + };
> > > + };
> > > };
> > > ...
> >
>
> Thank you for the review.
>
> 1. I updated the example indentation in order to use consistent 4-
> space indentation, instead of mixing with 2-space as in the
> previous version.
>
If that is needed, two patches. One that makes the address fix, then
a follow up to fix the indentation with no functional changes.
thanks,
Jonathan
> Best regards,
> Ariana
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: iio: dac: mcp47feb02: Fix I2C address in example
2026-04-20 10:36 [PATCH] dt-bindings: iio: dac: mcp47feb02: Fix I2C address in example Ariana Lazar
2026-04-20 12:22 ` Jonathan Cameron
@ 2026-04-20 12:29 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-20 12:29 UTC (permalink / raw)
To: Ariana Lazar, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Conor Dooley, Jonathan Cameron, linux-iio, devicetree,
linux-kernel
On 20/04/2026 12:36, Ariana Lazar wrote:
> Change example reg value from 0 to 0x60 in order to use a valid I2C address
>
> Fixes: 4ba12d304175 ("dt-bindings: iio: dac: adding support for Microchip MCP47FEB02")
No bug here, that's just example DTS, so drop the fixes. Otherwise
please explain the bug in commit msg.
> Link: https://lore.kernel.org/all/dd0dbadb-604b-4f12-8674-268b7db096fd@baylibre.com/
So you got this report 2 weeks ago and what happened exactly? What are
you fixing here?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-04-21 15:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-20 10:36 [PATCH] dt-bindings: iio: dac: mcp47feb02: Fix I2C address in example Ariana Lazar
2026-04-20 12:22 ` Jonathan Cameron
2026-04-21 14:09 ` Ariana.Lazar
2026-04-21 15:01 ` Jonathan Cameron
2026-04-20 12:29 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox