Re: [PATCH 1/2] iio: dac: adi-axi-dac: Make use of dev_err_probe()

["Nuno Sá" <noname.nuno@gmail.com>]

On Wed, 2025-12-03 at 10:06 -0600, David Lechner wrote:
> On 12/3/25 9:53 AM, Nuno Sá via B4 Relay wrote:
> > From: Nuno Sá <nuno.sa@analog.com>
> > 
> > Be consistent and use dev_err_probe() as in all other places in the
> > .probe() path.
> > 
> > While at it, remove the line break in the version condition. Yes, it
> > goes over the 80 column limit but I do think the line break hurts
> > readability in this case.
> > 
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
> >  drivers/iio/dac/adi-axi-dac.c | 20 +++++++++-----------
> >  1 file changed, 9 insertions(+), 11 deletions(-)
> > 
> > diff --git a/drivers/iio/dac/adi-axi-dac.c b/drivers/iio/dac/adi-axi-dac.c
> > index 0d525272a8a8..0c7b62f5357d 100644
> > --- a/drivers/iio/dac/adi-axi-dac.c
> > +++ b/drivers/iio/dac/adi-axi-dac.c
> > @@ -942,17 +942,15 @@ static int axi_dac_probe(struct platform_device *pdev)
> >  	if (ret)
> >  		return ret;
> >  
> > -	if (ADI_AXI_PCORE_VER_MAJOR(ver) !=
> > -		ADI_AXI_PCORE_VER_MAJOR(st->info->version)) {
> > -		dev_err(&pdev->dev,
> > -			"Major version mismatch. Expected %d.%.2d.%c, Reported %d.%.2d.%c\n",
> > -			ADI_AXI_PCORE_VER_MAJOR(st->info->version),
> > -			ADI_AXI_PCORE_VER_MINOR(st->info->version),
> > -			ADI_AXI_PCORE_VER_PATCH(st->info->version),
> > -			ADI_AXI_PCORE_VER_MAJOR(ver),
> > -			ADI_AXI_PCORE_VER_MINOR(ver),
> > -			ADI_AXI_PCORE_VER_PATCH(ver));
> > -		return -ENODEV;
> > +	if (ADI_AXI_PCORE_VER_MAJOR(ver) != ADI_AXI_PCORE_VER_MAJOR(st->info->version)) {
> 
> Can drop the braces now.

Yes, I thought about it but then kept the braces as we still have "multiple" lines (note checkpatch
does not complain in cases like this). 

But I don't feel strong about it so can drop them if you do :)

- Nuno Sá
> 
> >