Re: [PATCH 2/2] iio: dac: adi-axi-dac: Turn dev_info() into dev_dbg()

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Wed, Dec 03, 2025 at 10:14:41AM -0600, David Lechner wrote:
> On 12/3/25 10:10 AM, Nuno Sá wrote:
> > On Wed, 2025-12-03 at 10:05 -0600, David Lechner wrote:
> >> On 12/3/25 9:53 AM, Nuno Sá via B4 Relay wrote:

...

> >>> -	dev_info(&pdev->dev, "AXI DAC IP core (%d.%.2d.%c) probed\n",
> >>> -		 ADI_AXI_PCORE_VER_MAJOR(ver),
> >>> -		 ADI_AXI_PCORE_VER_MINOR(ver),
> >>> -		 ADI_AXI_PCORE_VER_PATCH(ver));
> >>> +	dev_dbg(&pdev->dev, "AXI DAC IP core (%d.%.2d.%c) probed\n",
> >>
> >> Didn't ADI HDL versioning policy change to semver so that the last number
> >> is no longer necessarily an ASCII character?
> >>
> >> We could probably change this to %d.%.d.%d while here.

I believe you don't want %.d and it was just a typo.

> > Honestly, I'm not sure how that settled up. I'll check and if that's the case I can change it.
> > But then it will be a bit messy with older IPs. Maybe moving this into debugfs and handle the format
> > there would make sense.
> 
> If it was still an ASCII value, it would just look like an unusually
> high bug fix number, but I don't think that hurts much. I don't think
> we need to go as far as changing it to debugfs. It should be pretty
> obvious if that is the case and people can figure out how to convert
> the number to a character.

One can always use a %pE for that. But if version grows up to printable
character... this all become screwed.

> The dev_err_probe() function in the previous patch in this series
> also has the same issue.

-- 
With Best Regards,
Andy Shevchenko