Re: [PATCH 2/2] iio: dac: adi-axi-dac: Turn dev_info() into dev_dbg()

["Nuno Sá" <noname.nuno@gmail.com>]

On Wed, 2025-12-03 at 10:14 -0600, David Lechner wrote:
> On 12/3/25 10:10 AM, Nuno Sá wrote:
> > On Wed, 2025-12-03 at 10:05 -0600, David Lechner wrote:
> > > On 12/3/25 9:53 AM, Nuno Sá via B4 Relay wrote:
> > > > From: Nuno Sá <nuno.sa@analog.com>
> > > > 
> > > > We should not abuse logging and logging a successful probe is clearly
> > > > abuse. Turn it into dev_dbg().
> > > > 
> > > > If it turns out the IP version is that relevant we can make it easy to
> > > > get through a new debugfs interface later on.
> > > > 
> > > > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > > > ---
> > > >  drivers/iio/dac/adi-axi-dac.c | 8 ++++----
> > > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > > > 
> > > > diff --git a/drivers/iio/dac/adi-axi-dac.c b/drivers/iio/dac/adi-axi-dac.c
> > > > index 0c7b62f5357d..f536158beb4c 100644
> > > > --- a/drivers/iio/dac/adi-axi-dac.c
> > > > +++ b/drivers/iio/dac/adi-axi-dac.c
> > > > @@ -1000,10 +1000,10 @@ static int axi_dac_probe(struct platform_device *pdev)
> > > >  						"cannot create device.");
> > > >  	}
> > > >  
> > > > -	dev_info(&pdev->dev, "AXI DAC IP core (%d.%.2d.%c) probed\n",
> > > > -		 ADI_AXI_PCORE_VER_MAJOR(ver),
> > > > -		 ADI_AXI_PCORE_VER_MINOR(ver),
> > > > -		 ADI_AXI_PCORE_VER_PATCH(ver));
> > > > +	dev_dbg(&pdev->dev, "AXI DAC IP core (%d.%.2d.%c) probed\n",
> > > 
> > > Didn't ADI HDL versioning policy change to semver so that the last number
> > > is no longer necessarily an ASCII character?
> > > 
> > > We could probably change this to %d.%.d.%d while here.
> > 
> > Honestly, I'm not sure how that settled up. I'll check and if that's the case I can change it.
> > But then it will be a bit messy with older IPs. Maybe moving this into debugfs and handle the
> > format
> > there would make sense.
> > 
> > - Nuno Sá
> > 
> > > 
> 
> If it was still an ASCII value, it would just look like an unusually
> high bug fix number, but I don't think that hurts much. I don't think
> we need to go as far as changing it to debugfs. It should be pretty
> obvious if that is the case and people can figure out how to convert
> the number to a character.
> 

Alright, but (unlike the spi_engine) it seems this core is still using the old format [1].

> The dev_err_probe() function in the previous patch in this series
> also has the same issue.

Right!

[1]: https://github.com/analogdevicesinc/hdl/blob/main/library/common/up_dac_common.v#L128
- Nuno Sá