From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Alisa-Dariana Roman" <alisa.roman@analog.com>,
"Haibo Chen" <haibo.chen@nxp.com>,
"Sean Nyekjaer" <sean@geanix.com>,
"Andreas Klinger" <ak@it-klinger.de>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 5/8] iio: adc: ad7192: Convert from of specific to fwnode property handling
Date: Mon, 19 Feb 2024 14:02:11 +0200 [thread overview]
Message-ID: <ZdNDQycAQ-EmKgQU@smile.fi.intel.com> (raw)
In-Reply-To: <20240218172731.1023367-6-jic23@kernel.org>
On Sun, Feb 18, 2024 at 05:27:28PM +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Enables use of with other firmwware types.
> Removes a case of device tree specific handlers that might get copied
> into new drivers.
...
> - dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X != 0x%X)\n",
> + dev_warn(dev, "device ID query failed (0x%X != 0x%X)\n",
> id, st->chip_info->chip_id);
Now id can be moved to the previous line (but it's up to you as you may argue
that this is the logical split).
...
> - burnout_curr_en = of_property_read_bool(np,
> - "adi,burnout-currents-enable");
> + burnout_curr_en = device_property_read_bool(dev,
> + "adi,burnout-currents-enable");
Same pattern as in the other patch?
burnout_curr_en =
device_property_read_bool(dev, "adi,burnout-currents-enable");
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-19 12:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 17:27 [PATCH 0/8] IIO: Convert DT specific handling over to fwnode Jonathan Cameron
2024-02-18 17:27 ` [PATCH 1/8] iio: adc: fsl-imx25-gcq: Switch from of specific handing to fwnode based Jonathan Cameron
2024-02-18 17:27 ` [PATCH 2/8] iio: adc: fsl-imx25-gcq: Use devm_* and dev_err_probe() to simplify probe Jonathan Cameron
2024-02-18 17:27 ` [PATCH 3/8] iio: adc: ad7124: Switch from of specific to fwnode based property handling Jonathan Cameron
2024-02-19 9:24 ` Nuno Sá
2024-02-19 11:59 ` Andy Shevchenko
2024-02-19 11:58 ` Andy Shevchenko
2024-02-24 15:19 ` Jonathan Cameron
2024-02-18 17:27 ` [PATCH 4/8] iio: adc: ad7292: Switch from of specific to fwnode " Jonathan Cameron
2024-02-19 9:26 ` Nuno Sá
2024-02-18 17:27 ` [PATCH 5/8] iio: adc: ad7192: Convert " Jonathan Cameron
2024-02-19 9:30 ` Nuno Sá
2024-02-19 12:02 ` Andy Shevchenko [this message]
2024-02-18 17:27 ` [PATCH 6/8] iio: accel: mma8452: Switch " Jonathan Cameron
2024-02-23 11:10 ` Bough Chen
2024-02-18 17:27 ` [PATCH 7/8] iio: accel: fxls8962af: Switch from of specific to fwnode based properties Jonathan Cameron
2024-02-19 12:03 ` Andy Shevchenko
2024-02-18 17:27 ` [PATCH 8/8] iio: adc: hx711: Switch from of specific to fwnode property handling Jonathan Cameron
2024-02-19 12:06 ` Andy Shevchenko
2024-02-19 12:06 ` [PATCH 0/8] IIO: Convert DT specific handling over to fwnode Andy Shevchenko
2024-02-24 15:31 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdNDQycAQ-EmKgQU@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=ak@it-klinger.de \
--cc=alisa.roman@analog.com \
--cc=haibo.chen@nxp.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox