Build failure on tpmdd master branch

Build failure on tpmdd master branch

[Nayna]

Hi Jarkko,

I rebased the "Enable loading local and third party keys on PowerVM 
guest"( 
https://lore.kernel.org/linux-integrity/20230714153435.28155-1-nayna@linux.ibm.com/) 
on top of tpmdd master branch.

The build is failing due to commit cfa7522f280a ("sysctl: set variable 
key_sysctls storage-class-specifier to static"). A patch with the same 
subject line is already in your tree. Refer to commit 0de030b30823 
("sysctl: set variable key_sysctls storage-class-specifier to static").

Thanks & Regards,

      - Nayna

Re: Build failure on tpmdd master branch

[Jarkko Sakkinen]

On Tue Aug 8, 2023 at 4:40 PM EEST, Nayna wrote:
> Hi Jarkko,
>
> I rebased the "Enable loading local and third party keys on PowerVM 
> guest"( 
> https://lore.kernel.org/linux-integrity/20230714153435.28155-1-nayna@linux.ibm.com/) 
> on top of tpmdd master branch.
>
> The build is failing due to commit cfa7522f280a ("sysctl: set variable 
> key_sysctls storage-class-specifier to static"). A patch with the same 
> subject line is already in your tree. Refer to commit 0de030b30823 
> ("sysctl: set variable key_sysctls storage-class-specifier to static").
>
> Thanks & Regards,
>
>       - Nayna

Thanks, I'll take a look!

BR, Jarkko

Re: Build failure on tpmdd master branch

[Jarkko Sakkinen]

On Tue Aug 8, 2023 at 4:40 PM EEST, Nayna wrote:
> Hi Jarkko,
>
> I rebased the "Enable loading local and third party keys on PowerVM 
> guest"( 
> https://lore.kernel.org/linux-integrity/20230714153435.28155-1-nayna@linux.ibm.com/) 
> on top of tpmdd master branch.
>
> The build is failing due to commit cfa7522f280a ("sysctl: set variable 
> key_sysctls storage-class-specifier to static"). A patch with the same 
> subject line is already in your tree. Refer to commit 0de030b30823 
> ("sysctl: set variable key_sysctls storage-class-specifier to static").
>
> Thanks & Regards,
>
>       - Nayna

Thanks for reporting, I rebased my tree and did:

make ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- defconfig
make ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-

I get this now:

security/integrity/ima/ima_crypto.c: In function ‘ima_pcrread’:
security/integrity/ima/ima_crypto.c:785:13: error: too few arguments to function ‘tpm_pcr_read’
  785 |         if (tpm_pcr_read(ima_tpm_chip, idx, d) != 0)
      |             ^~~~~~~~~~~~
In file included from security/integrity/ima/ima.h:21,
                 from security/integrity/ima/ima_crypto.c:23:
./include/linux/tpm.h:428:12: note: declared here
  428 | extern int tpm_pcr_read(struct tpm_chip *chip, u32 pcr_idx,
      |            ^~~~~~~~~~~~

BTW, in future, please also provide both arch and .config. I made
my guesses because I had neither (not meaning to complain, just
telling what would be useful, no worries).

BR, Jarkko

Re: Build failure on tpmdd master branch

[Jarkko Sakkinen]

On Thu Aug 10, 2023 at 10:02 PM EEST, Jarkko Sakkinen wrote:
> On Tue Aug 8, 2023 at 4:40 PM EEST, Nayna wrote:
> > Hi Jarkko,
> >
> > I rebased the "Enable loading local and third party keys on PowerVM 
> > guest"( 
> > https://lore.kernel.org/linux-integrity/20230714153435.28155-1-nayna@linux.ibm.com/) 
> > on top of tpmdd master branch.
> >
> > The build is failing due to commit cfa7522f280a ("sysctl: set variable 
> > key_sysctls storage-class-specifier to static"). A patch with the same 
> > subject line is already in your tree. Refer to commit 0de030b30823 
> > ("sysctl: set variable key_sysctls storage-class-specifier to static").
> >
> > Thanks & Regards,
> >
> >       - Nayna
>
> Thanks for reporting, I rebased my tree and did:
>
> make ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- defconfig
> make ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
>
> I get this now:
>
> security/integrity/ima/ima_crypto.c: In function ‘ima_pcrread’:
> security/integrity/ima/ima_crypto.c:785:13: error: too few arguments to function ‘tpm_pcr_read’
>   785 |         if (tpm_pcr_read(ima_tpm_chip, idx, d) != 0)
>       |             ^~~~~~~~~~~~
> In file included from security/integrity/ima/ima.h:21,
>                  from security/integrity/ima/ima_crypto.c:23:
> ./include/linux/tpm.h:428:12: note: declared here
>   428 | extern int tpm_pcr_read(struct tpm_chip *chip, u32 pcr_idx,
>       |            ^~~~~~~~~~~~
>
> BTW, in future, please also provide both arch and .config. I made
> my guesses because I had neither (not meaning to complain, just
> telling what would be useful, no worries).

I fixed the issue. The invalid and malformed commit is now dropped.

BR, Jarkko