Re: [PATCH v2 5/8] iommu/amd: Pass page table type as param to pdom_setup_pgtable()

[Jacob Pan <jacob.pan@linux.microsoft.com>]

Hi Vasant,

On Thu, 26 Sep 2024 15:55:14 +0530
Vasant Hegde <vasant.hegde@amd.com> wrote:

> Jacob,
> 
> 
> On 9/14/2024 3:09 AM, Jacob Pan wrote:
> > Hi Vasant,
> > 
> > On Wed, 11 Sep 2024 10:19:08 +0000
> > Vasant Hegde <vasant.hegde@amd.com> wrote:
> >   
> >> --- a/drivers/iommu/amd/iommu.c
> >> +++ b/drivers/iommu/amd/iommu.c
> >> @@ -2285,28 +2285,13 @@ struct protection_domain
> >> *protection_domain_alloc(unsigned int type, int nid) }
> >>  
> >>  static int pdom_setup_pgtable(struct protection_domain *domain,
> >> -			      unsigned int type)
> >> +			      unsigned int type, int pgtable)
> >>  {
> >>  	struct io_pgtable_ops *pgtbl_ops;
> >> -	int pgtable;
> >>  
> >> -	switch (type) {
> >>  	/* No need to allocate io pgtable ops in passthrough mode
> >> */
> >> -	case IOMMU_DOMAIN_IDENTITY:
> >> +	if (!(type & __IOMMU_DOMAIN_PAGING))
> >>  		return 0;  
> > Now that you pass in the pgtable format explicitly, I think you can
> > delete 'type' parameter and move this check to
> > do_iommu_domain_alloc(). As you mentioned in [4/8],
> > pdom_setup_pgtable() is factored out for setting up page table
> > only.  
> 
> I could have added check in do_iommu_domain_alloc(). As just kept it
> as is because eventually we can just remove this check. (Once I fix
> SVA domain and after having global static identity domain).
> 
sounds reasonable me.

Thanks,

Jacob