Re: [PATCH v2 5/8] iommu/amd: Pass page table type as param to pdom_setup_pgtable()

[Jason Gunthorpe <jgg@ziepe.ca>]

On Fri, Sep 13, 2024 at 02:39:45PM -0700, Jacob Pan wrote:
> Hi Vasant,
> 
> On Wed, 11 Sep 2024 10:19:08 +0000
> Vasant Hegde <vasant.hegde@amd.com> wrote:
> 
> > --- a/drivers/iommu/amd/iommu.c
> > +++ b/drivers/iommu/amd/iommu.c
> > @@ -2285,28 +2285,13 @@ struct protection_domain
> > *protection_domain_alloc(unsigned int type, int nid) }
> >  
> >  static int pdom_setup_pgtable(struct protection_domain *domain,
> > -			      unsigned int type)
> > +			      unsigned int type, int pgtable)
> >  {
> >  	struct io_pgtable_ops *pgtbl_ops;
> > -	int pgtable;
> >  
> > -	switch (type) {
> >  	/* No need to allocate io pgtable ops in passthrough mode */
> > -	case IOMMU_DOMAIN_IDENTITY:
> > +	if (!(type & __IOMMU_DOMAIN_PAGING))
> >  		return 0;
> Now that you pass in the pgtable format explicitly, I think you can
> delete 'type' parameter and move this check to do_iommu_domain_alloc().
> As you mentioned in [4/8], pdom_setup_pgtable() is factored out for
> setting up page table only.

It would be nice but I think the type is stil encoding the DMA API
flag at this point. Adjusting that could be moved to where the cookie
code ended up

Jason