Re: [PATCH v2 2/8] iommu: Introduce iommu_paging_domain_alloc_flags()

[Vasant Hegde <vasant.hegde@amd.com>]

Hi Jacob,


On 10/10/2024 2:44 AM, Jacob Pan wrote:
> Hi Vasant,
> 
> On Wed, 11 Sep 2024 10:19:05 +0000
> Vasant Hegde <vasant.hegde@amd.com> wrote:
> 
>> -struct iommu_domain *iommu_paging_domain_alloc(struct device *dev)
>> +struct iommu_domain *iommu_paging_domain_alloc_flags(struct device
>> *dev,
>> +						     unsigned int
>> flags) {
>> +	const struct iommu_ops *ops;
>> +	struct iommu_domain *domain;
>> +
>>  	if (!dev_has_iommu(dev))
>>  		return ERR_PTR(-ENODEV);
>>  
>> -	return __iommu_domain_alloc(dev_iommu_ops(dev), dev,
>> IOMMU_DOMAIN_UNMANAGED);
>> +	ops = dev_iommu_ops(dev);
>> +
>> +	if (ops->domain_alloc_paging && !flags)
>> +		domain = ops->domain_alloc_paging(dev);
>> +	else if (ops->domain_alloc_user)
>> +		domain = ops->domain_alloc_user(dev, flags, NULL,
>> NULL);
> Since this can be outside iommufd, the following comment needs update.

ACK. I will update.

-Vasant