From: Vasant Hegde <vasant.hegde@amd.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"joro@8bytes.org" <joro@8bytes.org>
Cc: "will@kernel.org" <will@kernel.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>, "Liu, Yi L" <yi.l.liu@intel.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"jacob.pan@linux.microsoft.com" <jacob.pan@linux.microsoft.com>
Subject: Re: [PATCH v3 09/12] iommu/amd: Enhance amd_iommu_domain_alloc_user()
Date: Wed, 23 Oct 2024 14:17:28 +0530 [thread overview]
Message-ID: <2d201519-830b-436d-8284-81caaa9df8c6@amd.com> (raw)
In-Reply-To: <BN9PR11MB527625CF817D73A8971AE9988C4C2@BN9PR11MB5276.namprd11.prod.outlook.com>
Kevin,,
On 10/22/2024 1:18 PM, Tian, Kevin wrote:
>> From: Vasant Hegde <vasant.hegde@amd.com>
>> Sent: Thursday, October 17, 2024 10:02 PM
>>
>> +
>> + /* Allocate domain with v2 page table if IOMMU supports PASID. */
>> + if (flags & IOMMU_HWPT_ALLOC_PASID) {
>> + if (!amd_iommu_pasid_supported())
>> + return ERR_PTR(-EINVAL);
>> +
>> + return do_iommu_domain_alloc(type, dev, flags,
>> AMD_IOMMU_V2);
>> + }
>> +
>> if ((flags & ~IOMMU_HWPT_ALLOC_DIRTY_TRACKING) || parent ||
>> user_data)
>> return ERR_PTR(-EOPNOTSUPP);
>
> swap the order and enhance above check to cover _PASID too.
Sure. Will fix it.
-Vasant
next prev parent reply other threads:[~2024-10-23 8:47 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 14:01 [PATCH v3 00/12] iommu: Domain allocation enhancements Vasant Hegde
2024-10-17 14:01 ` [PATCH v3 01/12] iommu: Refactor __iommu_domain_alloc() Vasant Hegde
2024-10-21 7:29 ` Yi Liu
2024-10-21 9:10 ` Vasant Hegde
2024-10-17 14:01 ` [PATCH v3 02/12] iommu: Introduce iommu_paging_domain_alloc_flags() Vasant Hegde
2024-10-18 3:29 ` Baolu Lu
2024-10-21 7:47 ` Yi Liu
2024-10-21 9:19 ` Vasant Hegde
2024-10-17 14:01 ` [PATCH v3 03/12] iommu: Add new flag to explictly request PASID capable domain Vasant Hegde
2024-10-18 3:43 ` Baolu Lu
2024-10-18 12:43 ` Jason Gunthorpe
2024-10-21 5:02 ` Baolu Lu
2024-10-18 14:16 ` Jason Gunthorpe
2024-10-21 10:02 ` Vasant Hegde
2024-10-21 7:57 ` Yi Liu
2024-10-23 8:52 ` Vasant Hegde
2024-10-21 7:59 ` Yi Liu
2024-10-22 4:54 ` Vasant Hegde
2024-10-17 14:01 ` [PATCH v3 04/12] iommu/arm-smmu-v3: Enhance domain_alloc_user() to allocate " Vasant Hegde
2024-10-18 14:23 ` Jason Gunthorpe
2024-10-21 8:57 ` Vasant Hegde
2024-10-17 14:01 ` [PATCH v3 05/12] iommu/amd: Add helper function to check GIOSUP/GTSUP Vasant Hegde
2024-10-18 14:23 ` Jason Gunthorpe
2024-10-17 14:01 ` [PATCH v3 06/12] iommu/amd: Move V2 page table support check to early_amd_iommu_init() Vasant Hegde
2024-10-18 14:24 ` Jason Gunthorpe
2024-10-17 14:01 ` [PATCH v3 07/12] iommu/amd: Separate page table setup from domain allocation Vasant Hegde
2024-10-17 14:01 ` [PATCH v3 08/12] iommu/amd: Pass page table type as param to pdom_setup_pgtable() Vasant Hegde
2024-10-18 14:25 ` Jason Gunthorpe
2024-10-17 14:01 ` [PATCH v3 09/12] iommu/amd: Enhance amd_iommu_domain_alloc_user() Vasant Hegde
2024-10-18 14:27 ` Jason Gunthorpe
2024-10-21 9:00 ` Vasant Hegde
2024-10-22 7:48 ` Tian, Kevin
2024-10-23 8:47 ` Vasant Hegde [this message]
2024-10-17 14:01 ` [PATCH v3 10/12] iommu/amd: Implement global identity domain Vasant Hegde
2024-10-17 14:01 ` [PATCH v3 11/12] iommu: Put domain allocation in __iommu_group_alloc_blocking_domain() Vasant Hegde
2024-10-18 4:02 ` Baolu Lu
2024-10-17 14:01 ` [PATCH v3 12/12] iommu: Create __iommu_alloc_identity_domain() Vasant Hegde
2024-10-18 4:04 ` Baolu Lu
2024-10-18 14:32 ` Jason Gunthorpe
2024-10-21 6:38 ` Vasant Hegde
2024-10-18 3:10 ` [PATCH v3 00/12] iommu: Domain allocation enhancements Baolu Lu
2024-10-18 12:50 ` Jason Gunthorpe
2024-10-21 9:08 ` Vasant Hegde
2024-10-22 7:50 ` Tian, Kevin
2024-10-23 8:48 ` Vasant Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d201519-830b-436d-8284-81caaa9df8c6@amd.com \
--to=vasant.hegde@amd.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.pan@linux.microsoft.com \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox