Re: [PATCH v3 09/12] iommu/amd: Enhance amd_iommu_domain_alloc_user()

[Jason Gunthorpe <jgg@ziepe.ca>]

On Thu, Oct 17, 2024 at 02:01:34PM +0000, Vasant Hegde wrote:
> Previous patch enhanced core layer to check device PASID capability and
> pass right flags to ops->domain_alloc_user().
> 
> Enhance amd_iommu_domain_alloc_user() to allocate domain with
> appropriate page table based on flags parameter.
>   - If flag is empty then allocate domain with default page table type.
>     This will eventually replace ops->domain_alloc().
>     For UNMANAGED domain, core will call this interface with flags=0. So
>     AMD driver will continue to allocate V1 page table.
> 
>   - If IOMMU_HWPT_ALLOC_PASID flag is passed then allocate domain with v2
>     page table.
> 
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> ---
>  drivers/iommu/amd/iommu.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> index cb6a72564c23..87eff85c0c23 100644
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -2404,6 +2404,20 @@ amd_iommu_domain_alloc_user(struct device *dev, u32 flags,
>  {
>  	unsigned int type = IOMMU_DOMAIN_UNMANAGED;
>  
> +	/* Allocate domain with default page table */
> +	if (!flags) {
> +		return do_iommu_domain_alloc(IOMMU_DOMAIN_DMA,
> +					     dev, 0, amd_iommu_pgtable);
> +	}

Extra {} ?

> +	/* Allocate domain with v2 page table if IOMMU supports PASID. */
> +	if (flags & IOMMU_HWPT_ALLOC_PASID) {
> +		if (!amd_iommu_pasid_supported())
> +			return ERR_PTR(-EINVAL);

Depending on what we decide this could be
amd_iommu_v2_pgtbl_supported()

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason