Re: [PATCH v3 1/5] iommu/amd: Remove iommu_v2 module

[Vasant Hegde <vasant.hegde@amd.com>]

Hi Alex,


On 9/28/2023 8:22 PM, Deucher, Alexander wrote:
> [AMD Official Use Only - General]
> 
>> -----Original Message-----
>> From: joro@8bytes.org <joro@8bytes.org>
>> Sent: Monday, September 25, 2023 5:05 AM
>> To: Jason Gunthorpe <jgg@nvidia.com>
>> Cc: Baolu Lu <baolu.lu@linux.intel.com>; Deucher, Alexander
>> <Alexander.Deucher@amd.com>; Hegde, Vasant <Vasant.Hegde@amd.com>;
>> iommu@lists.linux.dev; Suthikulpanit, Suravee
>> <Suravee.Suthikulpanit@amd.com>; Huang2, Wei <Wei.Huang2@amd.com>;
>> jsnitsel@redhat.com; Kuehling, Felix <Felix.Kuehling@amd.com>
>> Subject: Re: [PATCH v3 1/5] iommu/amd: Remove iommu_v2 module
>>
>> On Fri, Sep 22, 2023 at 09:18:12AM -0300, Jason Gunthorpe wrote:
>>> IMHO iommu drivers should not override this.
>>>
>>> I think it was a mistake that iommu drivers could override to identity
>>> domains. If we need quirks then the core code should have the quirk
>>> list, similar to how PCI works.
>>
>> Sounds reasonable, but if we transition over to an iommu core facility for
>> quirks, we must do it in a way that does not cause temporary regressions for
>> existing hardware.
>>
>> That being said, Alexander, can you please test this series for regressions on
>> the older hardware to make sure nothing regresses there?
>>
> 
> We've tested this and can confirm no regressions.

Thanks! I will add your 'Tested-by'. Hope you are fine with that.

-Vasant