From: Vasant Hegde <vasant.hegde@amd.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: iommu@lists.linux.dev, joro@8bytes.org,
suravee.suthikulpanit@amd.com, wei.huang2@amd.com,
jsnitsel@redhat.com
Subject: Re: [PATCH v4 12/14] iommu/amd: Introduce iommu_dev_data.flags to track device capabilities
Date: Wed, 16 Aug 2023 12:52:00 +0530 [thread overview]
Message-ID: <30462ffb-272a-78e9-bfe4-062e04cb7b1a@amd.com> (raw)
In-Reply-To: <ZNvFQU+OxRIt79C0@ziepe.ca>
Jason,
On 8/16/2023 12:04 AM, Jason Gunthorpe wrote:
> On Tue, Aug 15, 2023 at 10:22:00AM +0000, Vasant Hegde wrote:
>> Currently we use struct iommu_dev_data.iommu_v2 to keep track of the device
>> ATS, PRI, and PASID capabilities. But these capabilities can be enabled
>> independently (except PRI requires ATS support). Hence, replace
>> the iommu_v2 variable with a flags variable, which keep track of the device
>> capabilities.
>>
>> From commit 9bf49e36d718 ("PCI/ATS: Handle sharing of PF PRI Capability
>> with all VFs"), device PRI/PASID is shared between PF and any associated
>> VFs. Hence use pci_pri_supported() and pci_pasid_features() instead of
>> pci_find_ext_capability() to check device PRI/PASID support.
>
> One change per patch..
Since both changes are touching same part code and it was not big change, I just
made it as single patch.
-Vasant
next prev parent reply other threads:[~2023-08-16 7:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 10:21 [PATCH v4 00/14] iommu/amd: SVA Support (Part 1) - cleanup/refactoring Vasant Hegde
2023-08-15 10:21 ` [PATCH v4 01/14] iommu/amd: Remove unused amd_io_pgtable.pt_root variable Vasant Hegde
2023-08-16 15:37 ` Jerry Snitselaar
2023-08-15 10:21 ` [PATCH v4 02/14] iommu/amd: Consolidate timeout pre-define to amd_iommu_type.h Vasant Hegde
2023-08-16 15:39 ` Jerry Snitselaar
2023-08-15 10:21 ` [PATCH v4 03/14] iommu/amd: Consolidate logic to allocate protection domain Vasant Hegde
2023-08-16 15:42 ` Jerry Snitselaar
2023-08-15 10:21 ` [PATCH v4 04/14] iommu/amd: Refactor protection domain allocation code Vasant Hegde
2023-08-16 16:18 ` Jerry Snitselaar
2023-08-15 10:21 ` [PATCH v4 05/14] iommu/amd: Introduce helper functions for managing GCR3 table Vasant Hegde
2023-08-15 14:47 ` Jason Gunthorpe
2023-08-16 23:18 ` Jerry Snitselaar
2023-08-15 10:21 ` [PATCH v4 06/14] iommu/amd: Do not set amd_iommu_pgtable in pass-through mode Vasant Hegde
2023-08-16 16:26 ` Jerry Snitselaar
2023-08-15 10:21 ` [PATCH v4 07/14] iommu/amd: Miscellaneous clean up when free domain Vasant Hegde
2023-08-15 10:21 ` [PATCH v4 08/14] iommu/amd: Consolidate feature detection and reporting logic Vasant Hegde
2023-08-15 18:31 ` Jason Gunthorpe
2023-08-16 6:42 ` Vasant Hegde
2023-08-15 10:21 ` [PATCH v4 09/14] iommu/amd: Modify logic for checking GT and PPR features Vasant Hegde
2023-08-15 18:32 ` Jason Gunthorpe
2023-08-15 10:21 ` [PATCH v4 10/14] iommu/amd: Rename ats related variables Vasant Hegde
2023-08-15 10:21 ` [PATCH v4 11/14] iommu/amd: Introduce iommu_dev_data.ppr Vasant Hegde
2023-08-15 18:33 ` Jason Gunthorpe
2023-08-16 7:19 ` Vasant Hegde
2023-08-15 10:22 ` [PATCH v4 12/14] iommu/amd: Introduce iommu_dev_data.flags to track device capabilities Vasant Hegde
2023-08-15 18:34 ` Jason Gunthorpe
2023-08-16 7:22 ` Vasant Hegde [this message]
2023-08-15 10:22 ` [PATCH v4 13/14] iommu/amd: Enable device ATS/PASID/PRI capabilities independently Vasant Hegde
2023-08-15 10:22 ` [PATCH v4 14/14] iommu/amd: Initialize iommu_device->max_pasids Vasant Hegde
2023-08-15 18:35 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30462ffb-272a-78e9-bfe4-062e04cb7b1a@amd.com \
--to=vasant.hegde@amd.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=jsnitsel@redhat.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=wei.huang2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox