From: Jason Gunthorpe <jgg@ziepe.ca>
To: Vasant Hegde <vasant.hegde@amd.com>
Cc: iommu@lists.linux.dev, joro@8bytes.org,
suravee.suthikulpanit@amd.com, wei.huang2@amd.com,
jsnitsel@redhat.com
Subject: Re: [PATCH v4 14/14] iommu/amd: Initialize iommu_device->max_pasids
Date: Tue, 15 Aug 2023 15:35:22 -0300 [thread overview]
Message-ID: <ZNvFauXKrVg+Z1VO@ziepe.ca> (raw)
In-Reply-To: <20230815102202.565012-15-vasant.hegde@amd.com>
On Tue, Aug 15, 2023 at 10:22:02AM +0000, Vasant Hegde wrote:
> Commit 1adf3cc20d69 ("iommu: Add max_pasids field in struct iommu_device")
> introduced a variable struct iommu_device.max_pasids to track max
> PASIDS supported by each IOMMU.
>
> Let us initialize this field for AMD IOMMU. IOMMU core will use this value
> to set max PASIDs per device (see __iommu_probe_device()).
>
> Also remove unused global 'amd_iommu_max_pasid' variable.
>
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> ---
> drivers/iommu/amd/amd_iommu_types.h | 3 ---
> drivers/iommu/amd/init.c | 9 ++-------
> 2 files changed, 2 insertions(+), 10 deletions(-)
It looks OK, but you should still strive to remove the BUG_ON's in
this driver.
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
prev parent reply other threads:[~2023-08-15 18:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 10:21 [PATCH v4 00/14] iommu/amd: SVA Support (Part 1) - cleanup/refactoring Vasant Hegde
2023-08-15 10:21 ` [PATCH v4 01/14] iommu/amd: Remove unused amd_io_pgtable.pt_root variable Vasant Hegde
2023-08-16 15:37 ` Jerry Snitselaar
2023-08-15 10:21 ` [PATCH v4 02/14] iommu/amd: Consolidate timeout pre-define to amd_iommu_type.h Vasant Hegde
2023-08-16 15:39 ` Jerry Snitselaar
2023-08-15 10:21 ` [PATCH v4 03/14] iommu/amd: Consolidate logic to allocate protection domain Vasant Hegde
2023-08-16 15:42 ` Jerry Snitselaar
2023-08-15 10:21 ` [PATCH v4 04/14] iommu/amd: Refactor protection domain allocation code Vasant Hegde
2023-08-16 16:18 ` Jerry Snitselaar
2023-08-15 10:21 ` [PATCH v4 05/14] iommu/amd: Introduce helper functions for managing GCR3 table Vasant Hegde
2023-08-15 14:47 ` Jason Gunthorpe
2023-08-16 23:18 ` Jerry Snitselaar
2023-08-15 10:21 ` [PATCH v4 06/14] iommu/amd: Do not set amd_iommu_pgtable in pass-through mode Vasant Hegde
2023-08-16 16:26 ` Jerry Snitselaar
2023-08-15 10:21 ` [PATCH v4 07/14] iommu/amd: Miscellaneous clean up when free domain Vasant Hegde
2023-08-15 10:21 ` [PATCH v4 08/14] iommu/amd: Consolidate feature detection and reporting logic Vasant Hegde
2023-08-15 18:31 ` Jason Gunthorpe
2023-08-16 6:42 ` Vasant Hegde
2023-08-15 10:21 ` [PATCH v4 09/14] iommu/amd: Modify logic for checking GT and PPR features Vasant Hegde
2023-08-15 18:32 ` Jason Gunthorpe
2023-08-15 10:21 ` [PATCH v4 10/14] iommu/amd: Rename ats related variables Vasant Hegde
2023-08-15 10:21 ` [PATCH v4 11/14] iommu/amd: Introduce iommu_dev_data.ppr Vasant Hegde
2023-08-15 18:33 ` Jason Gunthorpe
2023-08-16 7:19 ` Vasant Hegde
2023-08-15 10:22 ` [PATCH v4 12/14] iommu/amd: Introduce iommu_dev_data.flags to track device capabilities Vasant Hegde
2023-08-15 18:34 ` Jason Gunthorpe
2023-08-16 7:22 ` Vasant Hegde
2023-08-15 10:22 ` [PATCH v4 13/14] iommu/amd: Enable device ATS/PASID/PRI capabilities independently Vasant Hegde
2023-08-15 10:22 ` [PATCH v4 14/14] iommu/amd: Initialize iommu_device->max_pasids Vasant Hegde
2023-08-15 18:35 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNvFauXKrVg+Z1VO@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=jsnitsel@redhat.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
--cc=wei.huang2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox