Re: [PATCH v4 09/14] iommu/amd: Modify logic for checking GT and PPR features

[Jason Gunthorpe <jgg@ziepe.ca>]

On Tue, Aug 15, 2023 at 10:21:57AM +0000, Vasant Hegde wrote:
> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> 
> In order to support v2 page table, IOMMU driver need to check if the
> hardware can support Guest Translation (GT) and Peripheral Page Request
> (PPR) features. Currently, IOMMU driver uses global (amd_iommu_v2_present)
> and per-iommu (struct amd_iommu.is_iommu_v2) variables to track the
> features. There variables area redundant since we could simply just check
> the global EFR mask.
> 
> Therefore, replace it with a helper function with appropriate name.
> 
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Co-developed-by: Vasant Hegde <vasant.hegde@amd.com>
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> ---
>  drivers/iommu/amd/amd_iommu.h       | 6 ++++++
>  drivers/iommu/amd/amd_iommu_types.h | 5 -----
>  drivers/iommu/amd/init.c            | 9 +--------
>  drivers/iommu/amd/iommu.c           | 2 +-
>  4 files changed, 8 insertions(+), 14 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason